Skip to content

Changes required to fix fast restart #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2025
Merged

Conversation

alan412
Copy link
Collaborator

@alan412 alan412 commented Jun 25, 2025

Oops, I realized that I had unintentionally broken fast restart by having an enum in a react file. I pulled it out which required updating a bunch of imports, but the logic is unchanged.

Eventually the type of module shouldn't be a tab type anyway, but that is more of a change than I wanted to do right now.

@alan412 alan412 requested a review from lizlooney June 25, 2025 02:20
lizlooney
lizlooney previously approved these changes Jun 28, 2025
@lizlooney lizlooney self-requested a review June 28, 2025 04:32
@lizlooney lizlooney dismissed their stale review June 28, 2025 05:04

I'm withdrawing my approval.

@alan412
Copy link
Collaborator Author

alan412 commented Jun 28, 2025

I am glad you caught that. I made both sets of changes based off of what VSCode was telling me were problems, but I think I confused it by switching branches that had different versions in it.

I looked through things and the changes in #124 were correct. Let me go add a commit removing those two changes from this one.

@alan412 alan412 requested a review from lizlooney June 28, 2025 12:59
@alan412
Copy link
Collaborator Author

alan412 commented Jun 28, 2025

Glad we squash. That is an embarrassing set of commits.

@lizlooney lizlooney merged commit e9663a9 into wpilibsuite:main Jun 28, 2025
1 check passed
@alan412 alan412 deleted the fix_hmr branch June 28, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants