Skip to content

PiHole module does not use auth token to get status #1615

Closed
@Muscaw

Description

@Muscaw

Hey, first of all, I'd like to say I'm super grateful for this repo to exist. I've been setting it up this morning and it's just awesome.

While setting up the pihole module, I noticed that the status does not show up. Basically, there is an unmarshal error when decoding the json.

Upon more investigation, I noticed that the requests is returning a HTTP 200, but the body is an empty json array.

The other requests (top clients and top domains) made by wtfutil to PiHole are working as expected and return expected values.

I'm happy to provide a PR with the fix.

What's broken?

The pihole module does not send the auth token when fetching the pihole server status. This results in a HTTP 200 response with empty array body. The pihole module tries to unmarshal it, but is ultimately unsuccessful

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions