Log before compressing

[TimaFrolov]

Right now logger gets called after response body has been compressed, which means it is logged in a non-human-readable format
Wouldn't it be better to log request before encoding the response body?

[yhirose]

@TimaFrolov thanks for the suggestion. It would be nice to do it, there are some difficulties. The easiest way to do this is to keep the original uncompressed text as well, but I don't prefer this approach since it may cause much more memory usage. Another way we may think is to log a response object right before compressing text. But it can't be done since the server will add more HTTP header values to the response object afterward...

I don't have a solution for it at this point, but I'll leave it as 'enhancement'.

[cplussharp]

I use this workaround in my log method:

#if defined(CPPHTTPLIB_ZLIB_SUPPORT) || defined(CPPHTTPLIB_BROTLI_SUPPORT)
    std::string encoding = res.get_header_value("Content-Encoding");
    std::unique_ptr<httplib::detail::decompressor> decompressor;
#ifdef CPPHTTPLIB_ZLIB_SUPPORT
    if (encoding == "gzip") {
        decompressor = httplib::detail::make_unique<httplib::detail::gzip_decompressor>();
    }
#endif
#ifdef CPPHTTPLIB_BROTLI_SUPPORT
    if (!decompressor && encoding == "br") {
        decompressor = httplib::detail::make_unique<httplib::detail::brotli_decompressor>();
    }
#endif
    if (decompressor && decompressor->is_valid()) {
        std::string decompressed;
        decompressor->decompress(res.body.c_str(), res.body.length(), [&](const char* buf, size_t n) {
            decompressed.append(buf);
            return true;
        });
        std::cout << decompressed;
    } else {
        std::cout << res.body;
    }
#else
    // body is always uncompressed
    std::cout << res.body;
#endif

maybe this can be moved into a helper method on the Response. Something like getUncompressedBody() or so.
Btw. is there a way to disable the compression in the server at runtime?