goctl: issues fix for goctl version 1.8.3 #4831
Closed
+89
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kesonan
commented
May 5, 2025
kesonan
commented
- fix About goctl not working after upgrade #4818
- remove example for swagger parameters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #4818 and removes examples for swagger parameters by updating the version build and adjusting related API generation logic. Key changes include:
- Bumping the BuildVersion from "1.8.3" to "1.8.4-beta".
- Removing the “Example” fields from swagger parameter definitions.
- Updating functions related to type generation and handler imports to pass an additional rootPkg parameter and to adjust default grouping logic.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/goctl/internal/version/version.go | Update BuildVersion to "1.8.4-beta". |
| tools/goctl/api/swagger/parameter.go | Remove example values from swagger parameters per issue fix. |
| tools/goctl/api/gogen/vars.go | Change default group type from "types" to an empty string. |
| tools/goctl/api/gogen/gentypes.go | Update functions to include rootPkg and add helper functions for grouping logic. |
| tools/goctl/api/gogen/genlogic.go | Adjust logic import generation to account for group annotations. |
| tools/goctl/api/gogen/genhandlers.go | Update handler import resolution to use updated group info. |
| tools/goctl/api/gogen/gen.go | Update genTypes invocation to include the rootPkg parameter. |
Files not reviewed (1)
- tools/goctl/api/gogen/types.tpl: Language not supported
Comments suppressed due to low confidence (2)
tools/goctl/api/gogen/vars.go:14
- Changing groupTypeDefault from "types" to an empty string may affect the default grouping logic. Please verify that downstream processing handles empty groups as intended.
groupTypeDefault = ""
tools/goctl/api/gogen/gentypes.go:69
- The addition of the 'rootPkg' parameter in genTypesWithGroup requires consistent handling in all calls. Please ensure that all invocations and usages are updated accordingly and that this change is documented if needed.
func genTypesWithGroup(dir, rootPkg string, cfg *config.Config, api *spec.ApiSpec) error {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.