Skip to content

Notify user when DMing a guest, based on setting #798

@gnprice

Description

@gnprice
Member

This is the zulip-flutter side of the following upcoming Zulip feature, with corresponding server/web and zulip-mobile issues:

The feature is probably landing in Zulip Server 9.0, so it'd be good to implement soon. That means:

  • consume that new setting from the server;
  • when appropriate, show a banner above the compose box similar to the one shown in Zulip web and zulip-mobile.

References

Activity

added
a-composeCompose box, autocomplete, attaching files/images
server-9Things new in Zulip Server 9.0
on Jul 10, 2024
added this to the Beta 3: Summer 2024 milestone on Jul 10, 2024
added
server-10Things new in Zulip Server 10.0
and removed
server-9Things new in Zulip Server 9.0
on Nov 21, 2024
gnprice

gnprice commented on Feb 6, 2025

@gnprice
MemberAuthor

This feature just landed in server and web, so it'll be in the upcoming Server 10 release. So that means we will indeed want to have it in time for the launch.

Abhisheksainii

Abhisheksainii commented on Feb 10, 2025

@Abhisheksainii

claiming this issue!

Abhisheksainii

Abhisheksainii commented on Feb 12, 2025

@Abhisheksainii

@gnprice is it possible that there could be a DM group with all the users being guests?

gnprice

gnprice commented on Feb 12, 2025

@gnprice
MemberAuthor

Hmm, I don't follow how that affects this issue.

The #mobile-dev-help channel is a good place to ask questions — more people will see it, and Zulip makes a better venue for back-and-forth discussion than GitHub.

added a commit that references this issue on Feb 16, 2025
0bc4083
added a commit that references this issue on Feb 19, 2025
0dcbc89
chimnayajith

chimnayajith commented on Mar 2, 2025

@chimnayajith
Contributor

I'd like to work on this.

AhmedTareek

AhmedTareek commented on Mar 6, 2025

@AhmedTareek
Contributor

Hello! 😊 I am new to contributing to Zulip, and I would love to have this issue assigned to me. I've already made some progress, which I show in the video below. There are still some refactorings and tests left to do before I can open my first PR for review.

I couldn't find a design for this on Figma, so I tried to follow the description from the issue here: zulip/zulip#30078. If the design needs to be changed, I'm happy to adjust it.

Also, I made the banner appear at the top instead of the bottom to always have a space at the end following this discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Mark-as-read/near/1680603

Screenrecorder-2025-03-06-22-25-05-360.mp4
gnprice

gnprice commented on Mar 6, 2025

@gnprice
MemberAuthor

Hello @AhmedTareek, welcome. @chimnayajith is already working on this issue, so I recommend looking around the tracker to find another issue to try.

(I've also just edited the issue description to link to the [design thread](* zulip/zulip#30078
) that @chimnayajith started for this issue.)

linked a pull request that will close this issue on Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a-composeCompose box, autocomplete, attaching files/imageshelp wantedserver-10Things new in Zulip Server 10.0

Type

No type

Projects

Status

No status

Relationships

None yet

    Participants

    @gnprice@chimnayajith@Abhisheksainii@AhmedTareek

    Issue actions

      Notify user when DMing a guest, based on setting · Issue #798 · zulip/zulip-flutter