-
Notifications
You must be signed in to change notification settings - Fork 320
Open
Labels
a-composeCompose box, autocomplete, attaching files/imagesCompose box, autocomplete, attaching files/imageshelp wantedserver-10Things new in Zulip Server 10.0Things new in Zulip Server 10.0
Milestone
Description
This is the zulip-flutter side of the following upcoming Zulip feature, with corresponding server/web and zulip-mobile issues:
- Add option to notify users when they are DMing a guest zulip#30078
- Notify users when they are DMing a guest based on setting zulip-mobile#5872
The feature is probably landing in Zulip Server 9.0, so it'd be good to implement soon. That means:
- consume that new setting from the server;
- when appropriate, show a banner above the compose box similar to the one shown in Zulip web and zulip-mobile.
References
- Design thread: #mobile-design > DMing a guest @ 💬
- Server/web issue: Add option to notify users when they are DMing a guest zulip#30078
- Similar feature but not directly related at a code level: Support new settings for restricting direct messages #791
Metadata
Metadata
Assignees
Labels
a-composeCompose box, autocomplete, attaching files/imagesCompose box, autocomplete, attaching files/imageshelp wantedserver-10Things new in Zulip Server 10.0Things new in Zulip Server 10.0
Type
Projects
Status
No status
Activity
gnprice commentedon Feb 6, 2025
This feature just landed in server and web, so it'll be in the upcoming Server 10 release. So that means we will indeed want to have it in time for the launch.
Abhisheksainii commentedon Feb 10, 2025
claiming this issue!
Abhisheksainii commentedon Feb 12, 2025
@gnprice is it possible that there could be a DM group with all the users being guests?
gnprice commentedon Feb 12, 2025
Hmm, I don't follow how that affects this issue.
The #mobile-dev-help channel is a good place to ask questions — more people will see it, and Zulip makes a better venue for back-and-forth discussion than GitHub.
message-list : add a prompt to notify guest(s) when DM
message-list : add a prompt to notify guest(s) when DM
chimnayajith commentedon Mar 2, 2025
I'd like to work on this.
AhmedTareek commentedon Mar 6, 2025
Hello! 😊 I am new to contributing to Zulip, and I would love to have this issue assigned to me. I've already made some progress, which I show in the video below. There are still some refactorings and tests left to do before I can open my first PR for review.
I couldn't find a design for this on Figma, so I tried to follow the description from the issue here: zulip/zulip#30078. If the design needs to be changed, I'm happy to adjust it.
Also, I made the banner appear at the top instead of the bottom to always have a space at the end following this discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Mark-as-read/near/1680603
Screenrecorder-2025-03-06-22-25-05-360.mp4
gnprice commentedon Mar 6, 2025
Hello @AhmedTareek, welcome. @chimnayajith is already working on this issue, so I recommend looking around the tracker to find another issue to try.
(I've also just edited the issue description to link to the [design thread](* zulip/zulip#30078
) that @chimnayajith started for this issue.)