[Fluent] Update NME to use fluent accordion for both nodeList and properties pane #16847
Conversation
georginahalpern
commented
Jul 3, 2025
georginahalpern
commented
- Update nodeListComponent to conditionally use accordion
- Update NME propertyTabComponents to use fluent accordion. This change required a bit of refactoring because the fluent accordion requires its first children to be the accordionItems, so in cases where we had wrappers around the LineContainer we would break the accordion. I thus had to push the accordion inside the individual fooPropertyTabComponent classes and in certain cases (ex: GenericProperties, InputProperties) where the properties were added dynamically, expose them via helper functions)
- Minor styling changes
…undefined values, add stub for material in iv2
|
LGTM, but I ll let @ryantrem comment out. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16847/merge/testResults/ |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
packages/dev/sharedUiComponents/src/components/propertyTabComponentBase.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/hoc/propertyLine.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/lines/draggableLineComponent.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/lines/draggableLineComponent.tsx
Outdated
Show resolved
Hide resolved
packages/tools/nodeEditor/src/graphSystem/properties/genericNodePropertyComponent.tsx
Outdated
Show resolved
Hide resolved
packages/tools/nodeEditor/src/graphSystem/properties/genericNodePropertyComponent.tsx
Show resolved
Hide resolved
packages/tools/nodeEditor/src/graphSystem/properties/genericNodePropertyComponent.tsx
Show resolved
Hide resolved
packages/tools/nodeEditor/src/graphSystem/properties/genericNodePropertyComponent.tsx
Outdated
Show resolved
Hide resolved
packages/tools/nodeEditor/src/graphSystem/properties/nodePortPropertyComponent.tsx
Show resolved
Hide resolved
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16847/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16847/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16847/merge#BCU1XR#0 |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16847/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16847/merge/ |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16847/merge/testResults/ |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16847/merge/testResults/ |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16847/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16847/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16847/merge#BCU1XR#0 |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16847/merge/ |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
1 similar comment
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16847/merge/ |
|
Visualization tests for WebGPU |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16847/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
WebGL2 visualization test reporter: |
