Skip to content

refactor(monorepo): add a new eslint for nestes components #18636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Jun 13, 2025

Overview

add a new eslint for nestes components and apply it to app and protocol-designer.

update app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/modals/RunFailedModal.tsx to fix lint error.

close AUTH-

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

add a new eslint for nestes components

close AUTH-
@koji
Copy link
Contributor Author

koji commented Jun 13, 2025

  • fix app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/modals/RunFailedModal.tsx

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 23.67%. Comparing base (71e6b93) to head (87be67b).
Report is 54 commits behind head on edge.

Files with missing lines Patch % Lines
...er/RunHeaderModalContainer/modals/ErrorContent.tsx 0.00% 51 Missing ⚠️
.eslintrc.js 0.00% 10 Missing ⚠️
.../RunHeaderModalContainer/modals/RunFailedModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18636      +/-   ##
==========================================
- Coverage   25.88%   23.67%   -2.21%     
==========================================
  Files        3279     3241      -38     
  Lines      284277   279994    -4283     
  Branches    28648    28509     -139     
==========================================
- Hits        73579    66289    -7290     
- Misses     210671   213678    +3007     
  Partials       27       27              
Flag Coverage Δ
protocol-designer 19.10% <0.00%> (-0.15%) ⬇️
step-generation 4.86% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../RunHeaderModalContainer/modals/RunFailedModal.tsx 0.00% <0.00%> (ø)
.eslintrc.js 0.00% <0.00%> (ø)
...er/RunHeaderModalContainer/modals/ErrorContent.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji changed the title chore(monorepo): add a new eslint for nestes components refactor(monorepo): add a new eslint for nestes components Jun 14, 2025
@koji koji marked this pull request as ready for review June 14, 2025 00:52
@koji koji requested review from a team as code owners June 14, 2025 00:52
@koji koji requested review from smb2268, a team and mjhuff and removed request for a team, smb2268 and mjhuff June 14, 2025 00:52
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This lint rule doesn't appear to be catching all instances (slack discussion), but I agree it's worth testing for a bit regardless. Thank you!

@koji koji merged commit ebcf5e2 into edge Jun 16, 2025
46 of 47 checks passed
@koji koji deleted the chore_add-eslint-for-nested-components branch June 16, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants