Skip to content

feat(step-generation): remove pd_step step wrapper #18647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

ddcc4
Copy link
Contributor

@ddcc4 ddcc4 commented Jun 16, 2025

Overview

We had defined a pd_step context manager so that we could group Python commands from the same PD step together, and so that we could emit fields from PD that are not expressible in the Python API (step name, step description, step form parameters, etc.). We were planning to use it like this:

with pd_step(name="My Mix Step", description="Mix very well", ...):
  pipette_left.pick_up_tip()
  pipette_left.mix(...)

However, command annotations serve the same purpose, and command annotations will also provide a context manager for grouping steps. So I'm removing our pd_step context manager.

Command annotations are not available in the public API yet, but we'll just wait for it and use it when it's available.

Test Plan and Hands on Testing

Updated unit tests.

Risk assessment

Low. Feature has never been released publicly.

@ddcc4 ddcc4 requested review from jbleon95 and jerader June 16, 2025 17:51
@ddcc4 ddcc4 requested a review from a team as a code owner June 16, 2025 17:51
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.89%. Comparing base (f461d0f) to head (e43b20b).
Report is 1 commits behind head on chore_release-pd-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-pd-8.5.0   #18647   +/-   ##
=======================================================
  Coverage                   25.89%   25.89%           
=======================================================
  Files                        3256     3256           
  Lines                      281301   281303    +2     
  Branches                    28539    28555   +16     
=======================================================
+ Hits                        72835    72854   +19     
+ Misses                     208439   208422   -17     
  Partials                       27       27           
Flag Coverage Δ
protocol-designer 19.11% <100.00%> (+<0.01%) ⬆️
step-generation 5.18% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
step-generation/src/utils/pythonFileUtils.ts 88.35% <100.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddcc4 ddcc4 merged commit cb2cae8 into chore_release-pd-8.5.0 Jun 16, 2025
30 of 32 checks passed
@ddcc4 ddcc4 deleted the dc-pdpy-pdstep branch June 16, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants