feat(step-generation): remove pd_step
step wrapper
#18647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We had defined a
pd_step
context manager so that we could group Python commands from the same PD step together, and so that we could emit fields from PD that are not expressible in the Python API (step name, step description, step form parameters, etc.). We were planning to use it like this:However, command annotations serve the same purpose, and command annotations will also provide a context manager for grouping steps. So I'm removing our
pd_step
context manager.Command annotations are not available in the public API yet, but we'll just wait for it and use it when it's available.
Test Plan and Hands on Testing
Updated unit tests.
Risk assessment
Low. Feature has never been released publicly.