Skip to content

fix(protocol-designer): disallow batch edit for multiple tips and pipette types #18651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 16, 2025

closes RQA-4279

Overview

The bug Alex found is because Alex tried to open batch edit and the flow rate field required a tiprack but the tiprack was undefined because there were 2 tiprack types in the multiple steps selected. The fix is to disallow batch edit from opening up if the steps include multiple tiprack types. and it extended to also disallow batch edit if the steps include multiple pipette types, this is because lots liquid class advanced settings require knowing both pipette and tiprack types.

Test Plan and Hands on Testing

Upload the protocol attached in the ticket (make sure you update the version to 8.5.0 so it doesn't goes through the migration by accident)

multi-select several transfer steps and see that it doesn't show an error

Changelog

  • disallow batch edit when you select on steps with multiple tiprack types or multiple pipette types

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 16, 2025 20:10
@jerader jerader requested review from koji and ncdiehl11 June 16, 2025 20:10
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 25.89%. Comparing base (f461d0f) to head (b57d753).
Report is 3 commits behind head on chore_release-pd-8.5.0.

Files with missing lines Patch % Lines
protocol-designer/src/ui/steps/selectors.ts 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-pd-8.5.0   #18651   +/-   ##
=======================================================
  Coverage                   25.89%   25.89%           
=======================================================
  Files                        3256     3256           
  Lines                      281301   281311   +10     
  Branches                    28539    28552   +13     
=======================================================
+ Hits                        72835    72844    +9     
- Misses                     208439   208440    +1     
  Partials                       27       27           
Flag Coverage Δ
protocol-designer 19.11% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tocol-designer/src/ui/steps/test/selectors.test.ts 95.02% <100.00%> (ø)
protocol-designer/src/ui/steps/selectors.ts 94.18% <90.00%> (-0.13%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader merged commit cb00b3e into chore_release-pd-8.5.0 Jun 17, 2025
16 checks passed
@jerader jerader deleted the pd_batch-edit-tiprack-bug branch June 17, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants