fix(abr-testing, scripts): fixes to Make files and adding build to pipfile #18661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegano1
reviewed
Jun 17, 2025
| @@ -35,6 +35,7 @@ $(if $(is-windows), echo "when using windows with an openSSH version larger then | |||
| define push-python | |||
| scp $(call id-file-arg,$(2)) $(scp-legacy-option-flag) $(3) $(4) root@$(1):/var/$(notdir $(4)) | |||
| scp $(call id-file-arg,$(2)) $(scp-legacy-option-flag) $(3) $(dir $(realpath $(lastword $(MAKEFILE_LIST))))/install-dist-remote.sh root@$(1):/var/ | |||
| ssh $(call id-file-arg,$(2)) $(3) root@$(1) chmod a+x /var/install-dist-remote.sh | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18661 +/- ##
==========================================
- Coverage 25.72% 23.88% -1.84%
==========================================
Files 3282 3282
Lines 283863 283858 -5
Branches 28576 28576
==========================================
- Hits 73016 67803 -5213
- Misses 210820 216030 +5210
+ Partials 27 25 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes to abr-testing make file and made the remote install script executable before running to avoid permission errors
Test Plan and Hands on Testing
Added build package to abr-testing pipfile
line added to
scripts/push.mkThis line ensures that the remote script /var/install-dist-remote.sh is made executable (chmod a+x) after it is copied to the robot via scp. On my computer I was running into permission issues before this line was added.
Changelog
Review requests
Risk assessment