fix(step-generation): extend unreachable temp timeline error to heate… #18674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18674 +/- ##
==========================================================
+ Coverage 23.83% 24.08% +0.24%
==========================================================
Files 3282 3256 -26
Lines 285228 281606 -3622
Branches 28688 28639 -49
==========================================================
- Hits 67992 67822 -170
+ Misses 217211 213759 -3452
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jerader
commented
Jun 18, 2025
| @@ -168,6 +168,7 @@ export function PauseTools(props: StepFormProps): JSX.Element { | |||
| <DropdownStepFormField | |||
| {...propsForFields.moduleId} | |||
| tooltipContent={null} | |||
| padding="0" | |||
There was a problem hiding this comment.
this padding allowed for the dropdown menu to span the whole width
ncdiehl11
approved these changes
Jun 18, 2025
| @@ -41,7 +41,7 @@ interface StepSummaryProps { | |||
| export function StepSummary(props: StepSummaryProps): JSX.Element | null { | |||
| const { currentStep, stepDetails } = props | |||
| const { t } = useTranslation(['protocol_steps', 'application']) | |||
| const unknownModule = t('unkonwn_module') | |||
| const unknownModule = t('unknown_module') | |||
| @@ -58,7 +58,9 @@ export const waitForTemperature: CommandCreator<TemperatureParams> = ( | |||
|
|
|||
| if ( | |||
| unreachableTemp || | |||
| ('status' in moduleState && moduleState.status === TEMPERATURE_DEACTIVATED) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r-shaker
closes RQA-4297
Overview
Fix a bug where there was no timeline error showing up for the attached protocol which caused an analysis failure since the error was not caught.
Test Plan and Hands on Testing
upload the protocol to PD and see that there is now a timeline error
doItAllV7.json
Changelog
Risk assessment
low