chore(protocol-designer): deprecate unused moveLiquid fields

[ncdiehl11]

Overview

Remove references to deprecated moveLiquid form fields:

• aspirate_delay_mmFromBottom
• dispense_delay_mmFromBottom
• blowout_z_offset

These fields are addressed by submerge/retract properties in PD 8.5.0.

Closes AUTH-1977

Test Plan and Hands on Testing

Please just check code and make sure I didn't accidentally deprecate anything unintended!

Changelog

• deprecate fields listed above in form-types and getDefaultsForFormType

Risk assessment

low

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.84%. Comparing base (a04052e) to head (2f5773d).
Report is 1 commits behind head on chore_release-pd-8.5.0.

Files with missing lines	Patch %	Lines
protocol-designer/src/load-file/migration/8_5_0.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18680      +/-   ##
==========================================================
+ Coverage                   24.88%   25.84%   +0.96%     
==========================================================
  Files                        3284     3256      -28     
  Lines                      285549   281312    -4237     
  Branches                    29088    28525     -563     
==========================================================
+ Hits                        71066    72715    +1649     
+ Misses                     214458   208570    -5888     
- Partials                       25       27       +2     

Flag	Coverage Δ
protocol-designer	19.05% <75.00%> (-0.11%)	⬇️
step-generation	5.19% <0.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ickTransferFlow/utils/generateQuickTransferArgs.ts	0.00% <ø> (ø)
protocol-designer/src/form-types.ts	46.29% <ø> (ø)
...src/step-forms/test/createPresavedStepForm.test.ts	96.46% <ø> (-0.03%)	⬇️
...r/src/steplist/formLevel/getDefaultsForStepType.ts	89.86% <ø> (-0.14%)	⬇️
.../steplist/formLevel/stepFormToArgs/getDelayData.ts	61.90% <100.00%> (+0.20%)	⬆️
...t/formLevel/stepFormToArgs/moveLiquidFormToArgs.ts	74.31% <ø> (-0.35%)	⬇️
...formLevel/stepFormToArgs/test/getDelayData.test.ts	94.40% <100.00%> (-0.53%)	⬇️
...l/stepFormToArgs/test/moveLiquidFormToArgs.test.ts	88.12% <100.00%> (-0.06%)	⬇️
...rmLevel/stepFormToArgs/test/stepFormToArgs.test.ts	92.92% <ø> (-0.07%)	⬇️
...list/formLevel/test/getDefaultsForStepType.test.ts	97.79% <ø> (-0.03%)	⬇️
... and 3 more

... and 263 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jerader]

looks good but shouldn't we also deprecate mmFromBottom in InnerDelayArgs in step-generation/src/types.ts? you deprecated the fields in the step form but not in the form to args.

[ncdiehl11]

looks good but shouldn't we also deprecate mmFromBottom in InnerDelayArgs in step-generation/src/types.ts? you deprecated the fields in the step form but not in the form to args.

Good call. I will rip that out as well

[jerader]

lgtm! thanks for squeezing this refactor in