Skip to content

fix(api): Always close the latch in home_all method of FlexStacker module. #18682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Jun 18, 2025

Overview

Sometimes we would not close the latch, even though error recovery would send the request because of internal states of the FlexStacker module. So we should always make sure we move the z axis if needed to make sure we close the latch if the ignore_latch is false.

Test Plan and Hands on Testing

  • Make sure the latch is closed when ignore_latch is false

Changelog

  • Always close the latch if the ignore_latch is false

Review requests

Risk assessment

@vegano1 vegano1 requested a review from a team as a code owner June 18, 2025 20:30
@vegano1 vegano1 requested a review from ahiuchingau June 18, 2025 20:30
Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet thank you!

@vegano1 vegano1 merged commit 3dd3a4e into edge Jun 18, 2025
29 of 30 checks passed
@vegano1 vegano1 deleted the flex-stacker-close-latch branch June 18, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants