Handle submodules with SSH URLs #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a documentation change, explaining how to fix submodules that are configured to use SSH URLs instead of HTTPS URLs. Spent a while banging my head on the wall and hope this saves someone else the pain. This is helpful for teams that use the SSH protocol for local development so don't want to change the mechanism that pulls in the submodules. Using `insteadOf` seems a bit nicer than than setting up a deploy keypair.
|
Oh my, I've been searching for this. Awesome work @csexton ! 👏 👏 👏 |
chrispat
reviewed
Feb 13, 2020
|
You beat me to it @chrispat! I was gonna come annotate the |
|
@csexton Thanks for raising the PR. I had a few minutes so I thought I would just annotate and merge. Hope I didn't step on your toes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a documentation change, explaining how to fix submodules that are configured to use SSH URLs instead of HTTPS URLs. Spent a while banging my head on the wall and hope this saves someone else the pain.
This is helpful for teams that use the SSH protocol for local development so don't want to change the mechanism that pulls in the submodules.