Skip to content

[windows] Fix syntax of ssh-keyscan #12223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

tvalenta
Copy link
Contributor

@tvalenta tvalenta commented May 20, 2025

Description

Remove extraneous spaces between key types to fetch. The Windows image has only the RSA key for github[.]com in file "C:\Program Files\Git\etc\ssh\ssh_known_hosts". This PR removes spaces in the list of key types so that neither ecdsa nor ed25519 are interpreted as hostnames

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Remove extraneous spaces between key types to fetch
@vidyasagarnimmagaddi vidyasagarnimmagaddi merged commit 9c70ef5 into actions:main Jun 26, 2025
9 checks passed
@tvalenta tvalenta deleted the fix-ssh-keyscan branch June 28, 2025 21:32
nikolai-in pushed a commit to nikolai-in/pve-runner-images that referenced this pull request Jul 8, 2025
Remove extraneous spaces between key types to fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants