Skip to content

Chore: update dev dependencies and workflows to node16 #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Apr 29, 2022

Node 12 is EOL soon, so lets go ahead and move to node 16

@thboop thboop requested a review from a team as a code owner April 29, 2022 15:43
Copy link
Contributor

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't want to need to continually update so many spots for this, you could consider using the newer node-version-file parameter of actions/setup-node combined with a .node-version file. 🙃

https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file

⚠️ In the Node version manager world, the only guaranteed format supported for a .node-version file is the entire 3-part SemVer version, e.g. 16.2.0, but the actions/setup-node code looks like it would still allow you to put a range like 16.x in it. 🤷🏻‍♂️

Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a Node version file, but otherwise looks good.

I was going to ask if we need to update to package-lock v2, but it looks like that's been done already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants