feat(fmt): remove UTF-8 BOM instead of maintaining it #29796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jun 18, 2025
cli/tools/fmt.rs
Outdated
|
|
||
| Ok(FileContents { text, had_bom }) | ||
| Ok(text) |
There was a problem hiding this comment.
I think we might need to still track when the file had a bom so that we can always overwrite that file to not have a bom.
dsherret
reviewed
Jun 18, 2025
| .with_context(|| { | ||
| anyhow!("{} is not a valid UTF-8 file", file_path.display()) | ||
| })?; | ||
| let text = deno_media_type::encoding::decode_owned_source( |
There was a problem hiding this comment.
I think this currently strips the bom internally: https://github.com/denoland/deno_media_type/blob/1aa277b0f182f23680f8077ee85266f0a95ddf8a/src/encoding.rs#L50
|
I have restored the FileContents struct as suggested. Please help review if this is the correct modification. Thank you! |
kingsword09
force-pushed
the
feat-fmt-remove-utf8-bom
branch
from
566f981 to
5e09624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29790