Skip to content

Commit bfb530b

Browse files
committed
Fix expected file comparer to handle missing files better in MaD workflows
1 parent 714659c commit bfb530b

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

misc/scripts/library-coverage/compare.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,26 @@ def compare_folders(folder1, folder2, output_file):
3737
# check if files exist in both folder1 and folder 2
3838
if not utils.check_file_exists(f"{folder1}/{generated_output_rst}"):
3939
expected_files += f"- {generated_output_rst} doesn't exist in folder {folder1}\n"
40+
utils.subprocess_check_output(
41+
["touch", f"{folder1}/{generated_output_rst}"])
4042
if not utils.check_file_exists(f"{folder2}/{generated_output_rst}"):
4143
expected_files += f"- {generated_output_rst} doesn't exist in folder {folder2}\n"
44+
utils.subprocess_check_output(
45+
["touch", f"{folder2}/{generated_output_rst}"])
4246
if not utils.check_file_exists(f"{folder1}/{generated_output_csv}"):
4347
expected_files += f"- {generated_output_csv} doesn't exist in folder {folder1}\n"
48+
utils.subprocess_check_output(
49+
["touch", f"{folder1}/{generated_output_csv}"])
4450
if not utils.check_file_exists(f"{folder2}/{generated_output_csv}"):
4551
expected_files += f"- {generated_output_csv} doesn't exist in folder {folder2}\n"
52+
utils.subprocess_check_output(
53+
["touch", f"{folder2}/{generated_output_csv}"])
54+
55+
return_md += f"\n### {lang}\n\n"
4656

4757
if expected_files != "":
4858
print("Expected files are missing", file=sys.stderr)
49-
return_md += f"\n### {lang}\n\n#### Expected files are missing for {lang}\n{expected_files}\n"
50-
continue
59+
return_md += f"#### Expected files are missing for {lang}\n{expected_files}\n"
5160

5261
# compare contents of files
5362
cmp1 = compare_files(
@@ -57,7 +66,7 @@ def compare_folders(folder1, folder2, output_file):
5766

5867
if cmp1 != "" or cmp2 != "":
5968
print("Generated file contents are not matching", file=sys.stderr)
60-
return_md += f"\n### {lang}\n\n#### Generated file changes for {lang}\n\n"
69+
return_md += f"#### Generated file changes for {lang}\n\n"
6170
if cmp1 != "":
6271
return_md += f"- Changes to {generated_output_rst}:\n```diff\n{cmp1}```\n\n"
6372
if cmp2 != "":

0 commit comments

Comments
 (0)