Ruby: demonstrate data flow not working with instance variables #7447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgran
force-pushed
the
jg/data-flow-instance-variables
branch
from
8c20927 to
bc8d434
Compare
owen-mc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch demonstrates an issue with data flow tracking. If you run this test on this branch you will see a failure, but this should pass.
The new ruby code I added to
ActiveRecordInjection.rbshows two identical methods, except one uses a local variable and one uses an instance variable.The local variable is successfully tracked as the
receiverof theDataFlow::CallNode, but the instance variable version is not.This makes it look to me like instance variables are not tracked properly in the dataflow module(s) yet.
This is catastrophic because instance variables are extremely common in ruby code, and especially for active record instances in rails controllers.