Skip to content

Set DownloadPipelineArtifactResourceTypes for v1 #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

fadnavistanmay
Copy link
Collaborator

Context

Similar to #5133, this sets the variable for V1 task as well.
https://dev.azure.com/mseng/1ES/_workitems/edit/2215567


Description

This PR adds the type of artifact downloaded by pipeline artifact task.
Build artifacts is not EO compliant due to its mutability. It is possible for DownloadPipelineArtifact to download a build artifact and we know that customers are doing this today. In this feature, we will beging emitting a warning when a build artifact is used with DownloadPipelineArtifact in release job and then eventually block it.


Risk Assessment (Low / Medium / High)

Low, since this is adding an environment variable.


Unit Tests Added or Updated (Yes / No)

Manual testing


@fadnavistanmay fadnavistanmay requested review from a team as code owners May 13, 2025 22:35
@fadnavistanmay
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@carl-tanner carl-tanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fadnavistanmay
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fadnavistanmay fadnavistanmay merged commit 4f682ba into master Jun 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants