Skip to content

feat(instrumentation-pg): update to stable semantic conventions #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jul 10, 2025

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Jun 10, 2025

Which problem is this PR solving?

Short description of the changes

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.07%. Comparing base (bcf32cd) to head (54275e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/instrumentation-pg/src/utils.ts 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   89.02%   89.07%   +0.04%     
==========================================
  Files         188      188              
  Lines        9197     9223      +26     
  Branches     1890     1900      +10     
==========================================
+ Hits         8188     8215      +27     
+ Misses       1009     1008       -1     
Files with missing lines Coverage Δ
packages/instrumentation-pg/src/instrumentation.ts 95.16% <100.00%> (+0.11%) ⬆️
packages/instrumentation-pg/src/internal-types.ts 100.00% <ø> (ø)
packages/instrumentation-pg/src/semconv.ts 100.00% <100.00%> (ø)
packages/instrumentation-pg/src/utils.ts 95.75% <88.46%> (-1.56%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing: It would be helpful, I think, to add a "Semantic Conventions" section to the instr-pg README, perhaps modelled after https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-http/README.md#semantic-conventions

@maryliag maryliag marked this pull request as ready for review June 13, 2025 19:58
@maryliag maryliag requested a review from a team as a code owner June 13, 2025 19:58
@maryliag
Copy link
Contributor Author

maryliag commented Jun 13, 2025

Still todo: add semantic conv section on README
Update tests

@maryliag
Copy link
Contributor Author

@trentm ready for review 😄

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have a test that we get the expected attributes for the different values of the OPT_IN envvar?

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits. Thanks for slogging through this.

@trentm trentm merged commit 4384c7b into open-telemetry:main Jul 10, 2025
23 checks passed
@dyladan dyladan mentioned this pull request Jul 10, 2025
@maryliag maryliag deleted the update-sem-pg branch July 10, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants