-
Notifications
You must be signed in to change notification settings - Fork 585
feat(instrumentation-pg): update to stable semantic conventions #2881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2881 +/- ##
==========================================
+ Coverage 89.02% 89.07% +0.04%
==========================================
Files 188 188
Lines 9197 9223 +26
Branches 1890 1900 +10
==========================================
+ Hits 8188 8215 +27
+ Misses 1009 1008 -1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing: It would be helpful, I think, to add a "Semantic Conventions" section to the instr-pg README, perhaps modelled after https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-http/README.md#semantic-conventions
plugins/node/opentelemetry-instrumentation-pg/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-pg/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
…trib into update-sem-pg
Still todo: add semantic conv section on README |
@trentm ready for review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have a test that we get the expected attributes for the different values of the OPT_IN
envvar?
…trib into update-sem-pg
…contrib into update-sem-pg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits. Thanks for slogging through this.
Co-authored-by: Trent Mick <trentm@gmail.com>
Co-authored-by: Trent Mick <trentm@gmail.com>
…trib into update-sem-pg
…contrib into update-sem-pg
Which problem is this PR solving?
Short description of the changes
OTEL_SEMCONV_STABILITY_OPT_IN
to decide when to send OLD, STABLE or BOTH (see https://opentelemetry.io/docs/specs/semconv/non-normative/db-migration/)