question on MERGE_REQUIRED_APPROVALS

[SamYuan1990]

Hi team,

May I know for MERGE_REQUIRED_APPROVALS, will this count for maintainers? or it will count all accounts?

Thanks and regards
Sam

[pascalgn]

I think it will count all accounts. I might be wrong, but I think in the past it wasn't possible to give "approval" reviews in repositories where one doesn't have write access to. But anyways, now it looks like it's possible, so the MERGE_REQUIRED_APPROVALS should only count reviews of people who have write access...

[SamYuan1990]

I think it will count all accounts. I might be wrong, but I think in the past it wasn't possible to give "approval" reviews in repositories where one doesn't have write access to. But anyways, now it looks like it's possible, so the MERGE_REQUIRED_APPROVALS should only count reviews of people who have write access...

ok, so once this one been fixed, we may able to have a try via sustainable-computing-io/kepler#249