Skip to content

Atlantis should post Pre Workflow Hooks failures if FailOnPreWorkflowHook is enabled #5615

Open
@mowirth

Description

@mowirth

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story
If a preworkflow hook fails, its status is currently reported to the VCS Provider.
However, the reason for the failure is not reported back to the end user, making it very hard to debug issues leading to the failure of the pre-workflow hook without having access to the atlantis logs.

Describe the solution you'd like
Atlantis should be able to post the output of the pre-workflow errors to the VCS provider (for example, Github).
This would allow developers to see the failure reason, and that there was a failure and atlantis did not just crash without ever generating a plan.

This feature can be protected by a feature flag, in case the pre-workflow hook result may contain sensitive information.

Describe the drawbacks of your solution

Describe alternatives you've considered
Only relying on pipeline status is not sufficient, as it is very quickly overlooked and potentially hidden behind hundreds of other pipeline statuses. Furthermore, the pipeline status does not provide additional information about the failure reason.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions