clippy fix: remove manual PartialEq::ne #143377
Open
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Note that implementations for reference types are not strictly the same as the default because they are forwarding of the underlying implementation. In such cases, if the compiler cannot optimize the inversion of the result from the underlying implementation (e.g., inline assembly or FFI is used), then |
|
@taiki-e that is a good point, thanks! |
rust-cloud-vms
bot
force-pushed
the
clippy-fix-5
branch
from
fe36c54 to
eac6335
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
clippy-fix-5
branch
from
eac6335 to
4489647
Compare
tgross35
reviewed
Jul 3, 2025
Comment on lines
+2027
to
+2029
| // if <A as PartialEq<B>>::ne uses inline assembly or FFI, then | ||
| // this forwarding impl may be more efficient than the default impl | ||
| #[allow(clippy::partialeq_ne_impl)] |
There was a problem hiding this comment.
Probably allow->expect so we get a bit of noise if these change for some reason.
Maybe just make this a module-level attribute? Since it applies to all but one fn ne in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes manual impls of PartialEq::ne which are equivalent to the default.