Skip to content

feat: allow developers to customize URL paths in CSS #20251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BUPTlhuanyu
Copy link

@BUPTlhuanyu BUPTlhuanyu commented Jun 20, 2025

Description

allow developers to customize URL paths in CSS

@BUPTlhuanyu BUPTlhuanyu changed the title feat: Allow developers to customize URL paths in CSS feat: allow developers to customize URL paths in CSS Jun 20, 2025
@BUPTlhuanyu
Copy link
Author

@patak-dev Are there alternative ways to achieve this functionality?

Comment on lines 136 to 143
expect(result.code).toMatchInlineSnapshot(
`
._foo_r7h0q_1 {
position: fixed;
background: url('/foo.png?vitebase=cdn');
}"
`,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline snapshot has a syntax error. There's an extra double quote at the end of line 141, and the closing backtick is missing. The correct format should be:

._foo_r7h0q_1 {
position: fixed;
background: url('/foo.png?vitebase=cdn');
}
`

This ensures the snapshot string is properly terminated and will match correctly during tests.

Suggested change
expect(result.code).toMatchInlineSnapshot(
`
._foo_r7h0q_1 {
position: fixed;
background: url('/foo.png?vitebase=cdn');
}"
`,
)
expect(result.code).toMatchInlineSnapshot(
`
._foo_r7h0q_1 {
position: fixed;
background: url('/foo.png?vitebase=cdn');
}
`,
)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant