-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update cloudflare.mdx #11928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudflare.mdx #11928
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Hi! I checked the docs at that link, and that appears to show this property as optional, and that it is for configuring a custom 404 page and overriding the defaults. I'm not sure we should include that here because it assumes that you have made a custom 404 page, and not everyone will have one. This guide was recently submitted by someone at Cloudflare themselves, so they probably feel this is the best general advice. In Astro docs, we avoid documenting too much about how third party services work, but we do want to be helpful! I will ask for some other team opinions about adding this. If this is something that most people would do, then it can be reasonable to show it. But, this might be something that it is better if they read Cloudflare's own docs if they want this feature, so that they understand how to do it and use it. |
Thanks for the suggestion. This options should only be used when two requirements are met: a) you are not using the Cloudflare adapter and have a 100% static page Since the deployment guide describes both approaches - using the adapter or non adapter - I think if we make sure this is added only to the correct tabs, we should recommend it. |
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Welcome to Team Docs @tobynguyen27 🙌
Description (required)
According to this docs
Cloudflare Workers doesn't serve 404.html by default. For static websites, we need to add
"not_found_handling": "404-page"
towrangler.json
to tell Workers serve themRelated issues & labels (optional)