Skip to content

This should fix bug #8296 : Crash in TipCache::findStates #8550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

hvlad
Copy link
Member

@hvlad hvlad commented May 4, 2025

No description provided.

@hvlad hvlad self-assigned this May 4, 2025
@hvlad hvlad requested a review from dyemanov May 4, 2025 09:31
@hvlad hvlad linked an issue May 4, 2025 that may be closed by this pull request
{
Sync sync(&m_sync_status, FB_FUNCTION);
getTransactionStatusBlock(header, blockNumber, sync);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to move Sync outside of the loop?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be unlocked before call of getTransactionStatusBlock() anyway.
mapInventoryPages() run once, no need to optimize it in this place, imho

@hvlad hvlad merged commit a20f9bb into master Jul 1, 2025
50 checks passed
hvlad added a commit that referenced this pull request Jul 1, 2025
* This should fix bug #8296 : Crash in TipCache::findStates

* Correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in TipCache::findStates
2 participants