-
-
Notifications
You must be signed in to change notification settings - Fork 243
Postfixes for PR#8145 #8571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postfixes for PR#8145 #8571
Conversation
Commit "Return isc_dsql_error prefix" has been undone because it caused more problems than solved. |
@asfernandes Do you have a testcase that fail on this build? |
Just one question: are your changes really needed for VARCHAR parameters? |
IMHO, yes. Some libraries do with them the same as with CHAR: overrun maximum length in characters as derived from maximum length in bytes while still fit to the storage. Besides, it suits to the standard's requirement to silently cut trailing blanks if they don't fit on store. Lastly it may help with API backward compatibility if longer VARCHARs are ever allowed. |
No description provided.