Skip to content

fix ISR in preview in cloudflare #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Conversation

conico974
Copy link
Contributor

Right now ISR breaks in preview because preview env doesn't have DO on them and the queue we use, use DO.
This PR fixes it by using a custom Queue that will use either the MemoryQueue in preview, or the classic DOQueue.
It also make sure that the queue call happens inside a waitUntil

Copy link

changeset-bot bot commented May 21, 2025

🦋 Changeset detected

Latest commit: d6b77d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook-v2 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented May 21, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 1 changed May 21, 2025, 7:40 AM
customers-v2 (Inspect) 👍 Changes approved 79 changed May 21, 2025, 7:41 AM
default (Inspect) 👍 Changes approved 1 changed May 21, 2025, 7:42 AM
v2-cloudflare (Inspect) ✅ No changes detected - May 21, 2025, 7:43 AM
v2-vercel (Inspect) ✅ No changes detected - May 21, 2025, 7:43 AM

@conico974 conico974 merged commit ba0094a into main May 21, 2025
21 checks passed
@conico974 conico974 deleted the cloudflare/fix-preview-isr branch May 21, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants