Skip to content

return null for 404 cached page in the incremental cache #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Conversation

conico974
Copy link
Contributor

This is a temp fix until it is properly fixed in OpenNext

Copy link

changeset-bot bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: 5b75810

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Jun 11, 2025, 10:49 AM
customers-v2 (Inspect) 👍 Changes approved 77 changed Jun 11, 2025, 10:49 AM
default (Inspect) ✅ No changes detected - Jun 11, 2025, 10:50 AM
v2-cloudflare (Inspect) ✅ No changes detected - Jun 11, 2025, 10:52 AM
v2-vercel (Inspect) ✅ No changes detected - Jun 11, 2025, 10:52 AM

Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully get this one, but trust you

@conico974 conico974 merged commit 2d64c78 into main Jun 11, 2025
21 checks passed
@conico974 conico974 deleted the cf/fix-on-404 branch June 11, 2025 11:47
@conico974
Copy link
Contributor Author

I don't fully get this one, but trust you

FYI, returning null means that we ignore the cache for this one. This is probably what we want to do anyway for 404 on cache interception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants