Skip to content

fix variant space change when pathname equals space-path #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

conico974
Copy link
Contributor

If the current page path equals the space path, the SpacesDropdown won't work for this space and you'll stay stuck on this specific space.
In this PR, for these cases, we always set the target url to the root of the other spaces

Copy link

linear bot commented Jun 17, 2025

Copy link

argos-ci bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Jun 17, 2025, 8:19 PM
customers-v2 (Inspect) ✅ No changes detected - Jun 17, 2025, 8:21 PM
default (Inspect) ✅ No changes detected - Jun 17, 2025, 8:21 PM
v2-cloudflare (Inspect) ✅ No changes detected - Jun 17, 2025, 8:22 PM
v2-vercel (Inspect) ✅ No changes detected - Jun 17, 2025, 8:23 PM

Copy link

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: 053b3fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@conico974 conico974 merged commit b4918f6 into main Jun 17, 2025
21 checks passed
@conico974 conico974 deleted the conico/rnd-6042 branch June 17, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants