Skip to content

Fix page group not expanded by default #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregberge
Copy link
Contributor

When the page is the root, the path is "". To test if a page is a
children of this one we have to test all possible paths of the page.

Copy link

linear bot commented Jun 19, 2025

Copy link

changeset-bot bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: 11e2fab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

When the page is the root, the path is "". To test if a page is a
children of this one we have to test all possible paths of the page.
Copy link

argos-ci bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Jun 19, 2025, 11:58 AM
customers-v2 (Inspect) 👍 Changes approved 74 changed Jun 19, 2025, 11:59 AM
default (Inspect) ✅ No changes detected - Jun 19, 2025, 12:01 PM
v2-cloudflare (Inspect) 👍 Changes approved 1 changed Jun 19, 2025, 12:01 PM
v2-vercel (Inspect) 👍 Changes approved 1 changed Jun 19, 2025, 12:25 PM

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there will be too many instance of this one. But if it starts to become a problem, we'll have to consider passing less data to it

@gregberge gregberge merged commit 8c0a53a into main Jun 19, 2025
31 of 32 checks passed
@gregberge gregberge deleted the greg/rnd-4525-page-groups-are-not-expanded-by-default-in-published-content branch June 19, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants