-
Notifications
You must be signed in to change notification settings - Fork 4k
Allow to zoom image on mobile if relevant #3364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ef289a2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of the deployments: Version 1
Version 2
Test content |
@@ -28,14 +30,9 @@ export function ZoomImage( | |||
|
|||
// Only allow zooming when image will not actually be larger and on mobile | |||
React.useEffect(() => { | |||
if (isTouchDevice()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why allow zoom on mobile? It'a a bad experience usually compared to zoom with the fingers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it was asked by a customer: RND-7089: Allow zooming images on mobile
And I think it's relevant because when you have small images like that it's good to be able to just touch it to expand it. It does not prevent from zooming with two fingers, so it's just a +.
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
No description provided.