Skip to content

Allow to zoom image on mobile if relevant #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregberge
Copy link
Contributor

No description provided.

Copy link

linear bot commented Jun 19, 2025

Copy link

changeset-bot bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: ef289a2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -28,14 +30,9 @@ export function ZoomImage(

// Only allow zooming when image will not actually be larger and on mobile
React.useEffect(() => {
if (isTouchDevice()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why allow zoom on mobile? It'a a bad experience usually compared to zoom with the fingers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was asked by a customer: RND-7089: Allow zooming images on mobile

And I think it's relevant because when you have small images like that it's good to be able to just touch it to expand it. It does not prevent from zooming with two fingers, so it's just a +.

Copy link

argos-ci bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Jun 19, 2025, 3:13 PM
customers-v2 (Inspect) 👍 Changes approved 74 changed Jun 19, 2025, 3:14 PM
default (Inspect) ✅ No changes detected - Jun 19, 2025, 3:16 PM
v2-cloudflare (Inspect) ✅ No changes detected - Jun 19, 2025, 3:17 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 1 changed Jun 19, 2025, 3:18 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants