github_runner_matrix: emulate plaform when sending compatible?
requests
#19873
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Closes #19838
There is a problem when CI determines which runners it needs when testing formulae. If a formula has
on_linux do
block withdepends_on arch:
requirement, it'll be added toformula.requirements
list, even if there's no such restriction on macOS. The opposite problem happens withon_macos
block. Because CI runs on Linux, it is not able to checkdepends_on arch:
there. To solve this problem, we need to simulate the specific platform when sending#{arch}_compatible?
request.Unfortunately, I don't know how to check if it works (I didn't find how to test
on_*
block ingithub_runner_matrix_spec.rb
), but I hope it will work as expected