cask/uninstall: fix HOME references in uninstall stanzas for multi-user installs
#19813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user installs Uninstall stanzas (e.g. `zap`) don't work correctly on multi-user installations where the user's UID might differ from the EUID. Let's try to fix that by ensuring that `~` is resolved to the running user's `HOME` (instead of the `HOME` of the EUID user).
carlocab
force-pushed
the
cask-home-uninstall
branch
from
00dfc69 to
b623341
Compare
This seems more reliable than using `trash.swift`.
carlocab
force-pushed
the
cask-home-uninstall
branch
from
554832f to
ac0dd6d
Compare
MikeMcQuaid
approved these changes
Apr 25, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Uninstall stanzas (e.g.
zap) don't work correctly on multi-userinstallations where the user's UID might differ from the EUID.
Let's try to fix that by ensuring that
~is resolved to the runninguser's
HOME(instead of theHOMEof the EUID user).