Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

sidenav: should be display: flex by default #10040

@sebakerckhof

Description

@sebakerckhof
Contributor

Actual Behavior:

Angular Versions: *

  • Angular Version: 1.5.8
  • Angular Material Version: 1.1.1

Activity

changed the title [-]md-sidenav should be `display: flex` by default.[/-] [+]sidenav: should be `display: flex` by default[/+] on Apr 20, 2020
added
needs: demoA CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue
on Apr 21, 2020
Splaktar

Splaktar commented on Apr 21, 2020

@Splaktar
Contributor

Here's a simple demo of this. It's true that we have the following behaviors:

  • Locked open: defined as display: flex
  • Open: defaults to display: block
  • Closed: defined as display: none

We should use display: flex for the Open state and not just default it to display: block.

added
P3: importantImportant issues that really should be fixed when possible.
and removed
needs: demoA CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue
on Apr 21, 2020
added this to the 1.1.23 milestone on Apr 21, 2020
modified the milestones: 1.1.23, 1.2.1, 1.2.0 on May 6, 2020
modified the milestones: 1.2.0, 1.2.1 on Jul 29, 2020
modified the milestones: 1.2.1, 1.2.2 on Sep 14, 2020
modified the milestones: 1.2.2, - Backlog on Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3: importantImportant issues that really should be fixed when possible.has: Pull RequestA PR has been created to address this issuetype: bug

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @sebakerckhof@Splaktar

      Issue actions

        sidenav: should be `display: flex` by default · Issue #10040 · angular/material