-
Notifications
You must be signed in to change notification settings - Fork 134
feat: tasklog groups #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: tasklog groups #347
Conversation
because you should use spacing instead.
🦋 Changeset detectedLatest commit: 569faa6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@example/basic • @example/changesets
commit: |
@yannbf if you get chance, can you have a play around with this via the pkg-pr-new install? im pretty happy with it so we just need to throw it around a bit and see if it falls over anywhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, just wondering if you're gonna add some tests in the future? 😁
also can you add a changeset please? 🙏🏻
100% - i got side tracked and ended up working on some other stuff ill try find some time to get back to this and add the tests etc |
tests + changeset added 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you James 🫡
This allows you to have tasklog groups.
Basically this:
this will result in a scrolling task log whose sub-logs have a
limit: 5
(i.e. the overall log has no such limit)once inner logs complete, they collapse as normal
once the overall log completes, we collapse the entire thing and output the log if specified
cc @yannbf