-
Notifications
You must be signed in to change notification settings - Fork 38
feat: CLI plugins SDK #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CLI plugins SDK #2091
Conversation
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gr0 . This is looking great. I've left a couple of comments.
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
67c1add
to
3d0f5da
Compare
3d0f5da
to
9b9ae91
Compare
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
909a8df
to
2366269
Compare
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Have a look at the following piece of code:
We are passing the configuration here. |
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Is that configuration the CA/CP APIs/CAs, current org and so on? |
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Yes, it includes the current organization, the token and so on. |
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
…m from cobra command Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, just make sure to rebase and take a look at my comment w.r.t the config behavior.
Thanks!
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
performing a release! 🎉 |
Thank you! |
This is an experimental approach to #2090 - the part of the whole solution providing the framework part.
I also created an example plugin that can be used for testing https://github.com/gr0/chainloop_example_plugin - everything that is needed is described in the readme file of the plugin.
Fixes #2091