Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grafana/grafana
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: coderabbitai/grafana
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: coderabbit_micro_frontend
Choose a head ref
  • 19 commits
  • 489 files changed
  • 22 contributors

Commits on Sep 3, 2024

  1. Update to latest (#184)

    * [v9.3.x] OAuth: Refactor OAuth parameters handling to support obtaining refresh tokens for Google OAuth (#58940)
    
    OAuth: Refactor OAuth parameters handling to support obtaining refresh tokens for Google OAuth (#58782)
    
    * Add ApprovalForce to AuthCodeOptions
    
    * Extract access token validity check to a function
    
    * Refactor
    
    * Oauth: set options internally instead of exposing new function
    
    * Align tests
    
    * Remove unused function
    
    Co-authored-by: Karl Persson <kalle.persson@grafana.com>
    (cherry picked from commit 9c98314)
    
    Co-authored-by: Misi <mgyongyosi@users.noreply.github.com>
    
    * [v9.3.x] Preferences: Add confirmation modal when saving org preferences (#59119) (#59141)
    
    * Navigation: share logic between `buildBreadcrumbs` and `usePageTitle`… (#59155)
    
    Navigation: share logic between `buildBreadcrumbs` and `usePageTitle` (#58819)
    
    * simplify usePageTitle logic a bit
    
    * use buildBreadcrumbs logic in usePageTitle
    
    * always add home item to navTree, fix some tests
    
    * fix remaining unit tests
    
    (cherry picked from commit 824a562)
    
    * [v9.3.x] CloudWatch: Cross-account querying support  (#59389)
    
    * add cross-account querying support
    
    * fix tests
    
    * FN FluxNinja changes
    
    * Run `go mod tidy`
    
    * Fix druid plugin registration
    
    * FN FluxNinja changes
    
    * FN FluxNinja changes
    
    * Build: Streamline and sync dockerfiles (#58101)
    
    * streamline and sync dockerfiles
    
    * improve go dependency cacheability
    
    * unify alpine and ubuntu Dockerfiles
    
    * include glibc support in locally-built alpine images
    
    * FN Remove internationalization provider
    
    * FN Update sankey panel (30b5be0b5bf03ee8c7)
    
    * FN Render filters and time selector, hide loader despite pageNav and sectionNav
    
    * FN Remove tenary expressions with explicit booleans in DashNav
    
    * FN Use optional chaining - keybindingSrv in initDashboard
    
    * FN Set isPublicDashboardView to false
    
    * FN Set hiddenVariables in initial FN state
    
    * FN Lint RenderFnDashboard
    
    * FN Lint create-mfe
    
    * Updated SSH Keys (#43)
    
    * Time range selector changes (#42)
    
    * changed time picker dropdown designs
    
    * change time setting button
    
    * added dark and light
    
    * 7829 Read hiddenVariables, mode, FNDashboard from grfana's state (#44)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * Add tool versions (#45)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * Added support for updating nightly environment (#46)
    
    * 7911 Add graphql datasource plugin (#47)
    
    * 7911 Update FN_README
    
    * 7911 Add graphql plugin
    
    * 7911 Add graphql plugin
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * 7911 Allow loading unsigned graphql plugin (#49)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * 7911 Modify url in graphql datasource plugin (#50)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * Minor grafadruid fixes (#51)
    
    * Support Druid GroupBy queries (#52)
    
    * 8225 Fix missing grafana loader (#53)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * Fix ad hoc filters (#54)
    
    * 8238 Remove panel header menu (#55)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * added presisted time range (#56)
    
    * Updates to latest instead of demo environment (#57)
    
    * Loading dashboards with update function (#58)
    
    * changed dashboard loading to use update fn
    
    * removed extra package
    
    * changed query filter designs (#59)
    
    * Add ChatGPT-based PR Reviewer and Summarizer (#62)
    
    * fix (#63)
    
    * 8822 ci (#66)
    
    * 8822 Remove dashes from dashboard filter labels
    
    * 8822 Empty commit
    
    ---------
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * 8740 Fix variables in titles by using PanelHeader component to render panel header (#64)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * update action
    
    * update review job name (#69)
    
    * Load dashboard with specific version passed from FN UI (#68)
    
    * Add full metadata for versions query too (#70)
    
    * 8963 Remove edit icons in dashboard row (#71)
    
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    
    * Update openai-review.yml (#73)
    
    * Update openai-review.yml
    
    * update action
    
    * Fix table panel (#75)
    
    * Grafana firefox (#77)
    
    * vscode fix
    
    * fixed firefox bugs
    
    ---------
    
    Co-authored-by: Gurinder Singh <gurnder.rawala@fluxninja.com>
    
    * Pull latest time range changes from upstream grafana (#78)
    
    * Support math expressions for druid granularity (#81)
    
    * Remove font size from global styles (#82)
    
    * Add fnLoader in grafana instead of prop from parent mfe (#83)
    
    * Fixed CircleCI config (#84)
    
    * Font update, bug fixes (#85)
    
    * Fix grafana bugs
    
    * Update grafana font to source sans pro
    
    * Revert code format change
    
    * replace function error fix (#87)
    
    * Add missing config in opsninja.yaml (#88)
    
    * Update font to Source Sans Pro (#90)
    
    * filter label design fix (#92)
    
    * druid datasource fixes (#93)
    
    * druid datasource fixes
    
    * wire gen fix
    
    * page definations fix (#94)
    
    * Fix headers in Druid DS (#97)
    
    Co-authored-by: Jakub Michalak <jakub.michalak@fluxninja.com>
    
    * Pass headers to Druid query (#99)
    
    * Fix headers in Druid variable queries (#100)
    
    * typing error fix and modifications (#101)
    
    * typing error fix and modifications
    
    * react-use module installed
    
    * Fix type error and adhoc filter alignment
    
    * Fix one more type error
    
    ---------
    
    Co-authored-by: Spikatrix <12792882+Spikatrix@users.noreply.github.com>
    
    * render time range selector any where, removed dead code (#103)
    
    * removed graphql data source, updated local test info in fn readme
    
    * portal for time range selector
    
    * Enable panel resizing (#105)
    
    * Adhoc filter fix, update sankey plugin (#106)
    
    * Adhoc filter style fix
    
    * Update sankey plugin
    
    * confirm grafana initialization (#107)
    
    * window event to confirm initialization
    
    * grafana start up status events
    
    * Show filters icon only when there are some variables to show (#116)
    
    * Don't panic on empty var Druid query (#123)
    
    * Remove not needed GH Actions (#124)
    
    * changed to cirular progress (#148)
    
    * changed to cirular progress
    
    * codeRabbit suggestions
    
    * remove reviewer
    
    * loader color fix (#150)
    
    * page title Flux Ninja -> FluxNinja
    
    * Add allowed cookies field in druid datasource settings (#171)
    
    * Fix sentry heatmap crash (#168)
    
    Co-authored-by: Gurinder Singh <gurinder.rawala@fluxninja.com>
    
    * removed make doc workflow (#172)
    
    * Coderabbit theme and fixes (#175)
    
    * coderabbit theme
    
    * theme change
    
    * checkpoint
    
    * fixes
    
    * added coderabbit authentication
    
    * Create deploy-cloud-run-grafana.yaml (#176)
    
    * Update deploy-cloud-run-grafana.yaml
    
    * Update deploy-cloud-run-grafana.yaml with CD
    
    * webpack fix for prod (#177)
    
    * added GH for prod (#178)
    
    Co-authored-by: dikshant <raidikshant2@gmail.com>
    
    * Deploy grafana image to cloud run
    
    * Update deploy-cloud-run-grafana-prod.yaml
    
    * dashboard style changes (#179)
    
    * disabled drag for mfe (#180)
    
    * changed error message to no data (#182)
    
    * fix
    
    * log fix
    
    * rebase issues resolved
    
    * webpack changes
    
    * mfe fix
    
    * checkpoint
    
    * tooltip, icons fix
    
    * deleted github actions
    
    * dependency updates fix
    
    * fixes
    
    ---------
    
    Co-authored-by: Grot (@grafanabot) <43478413+grafanabot@users.noreply.github.com>
    Co-authored-by: Misi <mgyongyosi@users.noreply.github.com>
    Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com>
    Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
    Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>
    Co-authored-by: Katarzyna Ziomek-Zdanowicz <katarzyna.ziomek-zdanowicz@fluxninja.com>
    Co-authored-by: Krzysztof Kwapisiewicz <krzysztof.kwapisiewicz@fluxninja.com>
    Co-authored-by: Dan Cech <dcech@grafana.com>
    Co-authored-by: Hardik Shingala <34568645+hdkshingala@users.noreply.github.com>
    Co-authored-by: Gurinder Singh <108446046+gurinder39@users.noreply.github.com>
    Co-authored-by: Kasia <24753130+ziomecka@users.noreply.github.com>
    Co-authored-by: Szymon Bieńkowski <szymon.bienkowski@fluxninja.com>
    Co-authored-by: Jakub Michalak <jakub.michalak@fluxninja.com>
    Co-authored-by: Harjot Gill <harjot.gill@fluxninja.com>
    Co-authored-by: Daria Bialobrzeska <88393714+DariaKunoichi@users.noreply.github.com>
    Co-authored-by: Gurinder Singh <gurnder.rawala@fluxninja.com>
    Co-authored-by: Jaseel <12792882+Spikatrix@users.noreply.github.com>
    Co-authored-by: Gurinder Singh <gurinder.rawala@fluxninja.com>
    Co-authored-by: dikshant-infracloud <160205839+dikshant-infracloud@users.noreply.github.com>
    Co-authored-by: dikshant <raidikshant2@gmail.com>
    21 people authored Sep 3, 2024

    Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
    Copy the full SHA
    68b353a View commit details

Commits on Sep 4, 2024

  1. workflows fix (#185)

    * workflows fix
    
    * grafana build
    
    * suggested changes
    
    * fix
    
    * working_directory path fix
    
    * using orbs
    
    * rolled back to docker and new images
    
    * build fix
    
    * go build fix
    
    * go backend run cmd
    
    * removed go build in circleci
    GurinderRawala authored Sep 4, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    24b0abd View commit details

Commits on Sep 5, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c83f2af View commit details
  2. webpack fix and warning fixes (#187)

    * webpack fix and warning fixes
    
    * fix
    
    * should log fix
    GurinderRawala authored Sep 5, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    7264168 View commit details

Commits on Sep 6, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f69ec4e View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    2710396 View commit details

Commits on Oct 4, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    71c9177 View commit details

Commits on Oct 17, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    de00151 View commit details

Commits on Oct 24, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    04a4be1 View commit details

Commits on Oct 25, 2024

  1. changed colors (#191)

    GurinderRawala authored Oct 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    4e1ac22 View commit details

Commits on Nov 11, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f633be4 View commit details

Commits on Jan 8, 2025

  1. scoping query using rls (#194)

    * scoping query using rls
    
    * fixed log
    GurinderRawala authored Jan 8, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    9f51b61 View commit details

Commits on Mar 24, 2025

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    874cb7a View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    9086dab View commit details

Commits on Mar 25, 2025

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    3dcf553 View commit details

Commits on Apr 25, 2025

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    755f999 View commit details

Commits on May 29, 2025

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    0ffaebc View commit details

Commits on Jun 6, 2025

  1. Drill down metrics (#200)

    * multiple dashboards on same page
    
    * fix
    
    * time range selector fix
    GurinderRawala authored Jun 6, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    9624da6 View commit details

Commits on Jun 10, 2025

  1. theme fix

    GurinderRawala committed Jun 10, 2025
    Copy the full SHA
    94f75e5 View commit details
Showing 489 changed files with 18,339 additions and 11,330 deletions.
9 changes: 1 addition & 8 deletions .betterer.results
Original file line number Diff line number Diff line change
@@ -1296,11 +1296,7 @@ exports[`better eslint`] = {
],
"public/app/core/services/backend_srv.ts:5381": [
[0, 0, 0, "Do not use any type assertions.", "0"],
[0, 0, 0, "Unexpected any. Specify a different type.", "1"],
[0, 0, 0, "Unexpected any. Specify a different type.", "2"],
[0, 0, 0, "Unexpected any. Specify a different type.", "3"],
[0, 0, 0, "Unexpected any. Specify a different type.", "4"],
[0, 0, 0, "Unexpected any. Specify a different type.", "5"]
[0, 0, 0, "Do not use any type assertions.", "1"]
],
"public/app/core/services/context_srv.ts:5381": [
[0, 0, 0, "Do not use any type assertions.", "0"],
@@ -3103,9 +3099,6 @@ exports[`better eslint`] = {
[0, 0, 0, "Do not use any type assertions.", "7"],
[0, 0, 0, "Unexpected any. Specify a different type.", "8"]
],
"public/app/features/dashboard/components/DashboardRow/DashboardRow.test.tsx:5381": [
[0, 0, 0, "Unexpected any. Specify a different type.", "0"]
],
"public/app/features/dashboard/components/DashboardRow/DashboardRow.tsx:5381": [
[0, 0, 0, "No untranslated strings. Wrap text with <Trans />", "0"],
[0, 0, 0, "No untranslated strings. Wrap text with <Trans />", "1"],
59 changes: 59 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
version: 2.1

executors:
go-executor:
docker:
- image: cimg/go:1.22.6
working_directory: ~/github.com/grafana

node-executor:
docker:
- image: cimg/node:22.7.0
working_directory: ~/frontend
resource_class: large

jobs:
go-mod-install:
executor: go-executor
steps:
- checkout
- restore_cache:
keys:
- go-mod-cache-{{ checksum "go.sum" }}
- go-mod-cache-
- run:
name: Install Go dependencies
command: go mod download
- run:
name: Go mod tidy
command: go mod tidy
- save_cache:
paths:
- ~/go/pkg/mod
key: go-mod-cache-{{ checksum "go.sum" }}

build-frontend:
executor: node-executor
steps:
- checkout
- restore_cache:
keys:
- yarn-cache-{{ checksum "yarn.lock" }}
- yarn-cache-
- run:
name: Install frontend dependencies
command: yarn install --immutable
- save_cache:
paths:
- ~/.cache/yarn
key: yarn-cache-{{ checksum "yarn.lock" }}
- run:
name: Build frontend
command: yarn run build

workflows:
version: 2
build-and-test:
jobs:
- go-mod-install
- build-frontend
23 changes: 23 additions & 0 deletions .circleci/scripts/asdf_install.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/usr/bin/env bash
set -euo pipefail
set -x

# shellcheck disable=SC2153
readarray -t tools <<<"${TOOLS?}"
if [ "${#tools[@]}" -eq 1 ] && [ -z "${tools[0]:-}" ]; then
# Parameter was set to empty string
tools=()
fi

sudo apt-get update
sudo apt-get install graphviz

# If we need to setup python
if grep <<<"${TOOLS}" '^python$'; then
# See https://github.com/pyenv/pyenv/wiki#suggested-build-environment
sudo apt-get install make build-essential libssl-dev zlib1g-dev \
libbz2-dev libreadline-dev libsqlite3-dev wget curl llvm \
libncursesw5-dev xz-utils tk-dev libxml2-dev libxmlsec1-dev libffi-dev liblzma-dev
fi

(yes || true) | ./.circleci/scripts/manage_tools.sh setup "${tools[@]}"
122 changes: 122 additions & 0 deletions .circleci/scripts/manage_tools.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
#!/usr/bin/env bash

set -euo pipefail

git_root="$(git rev-parse --show-toplevel)"
readonly git_root="${git_root}"
readonly version_file="${git_root}"/.tool-versions

set -x

add_plugins() {
check_asdf

[ -f "$version_file" ] || {
printf 'ASDF .tool-versions does not exist. Exiting\n'
return 1
}

readarray -t intended_plugins < <(cut -d" " -f1 "${version_file}")
readarray -t added_plugins < <(asdf plugin-list)
if [ "${#@}" -eq 0 ]; then
local -r wanted_plugins=("${intended_plugins[@]}")
else
local -r wanted_plugins=("${@}")
fi

local plugin
for plugin in "${wanted_plugins[@]}"; do
if ! array_contains "${plugin}" "${intended_plugins[@]}"; then
printf 'The specified tool %s is not specified in ASDF config!\n' "${plugin}"
printf 'Declared plugins: %s\n' "${intended_plugins[*]}"
return 1
fi
done

for plugin in "${wanted_plugins[@]}"; do
if ! array_contains "${plugin}" "${added_plugins[@]}"; then
printf 'Adding asdf plugin: "%s"\n' "${plugin}"
asdf plugin add "${plugin}"
fi
done
}

install_plugins() {
check_asdf
if [ "${#@}" = 0 ]; then
asdf install
else
local plug
for plug in "${@}"; do
asdf install "${plug}"
done
fi

if python --version &>/dev/null; then
printf 'Installing Python tools\n'
# install python tools
pushd "${git_root}" >/dev/null
pip install -r "${git_root}"/requirements.txt
popd >/dev/null
fi
if asdf where python &>/dev/null; then
asdf reshim python
fi
}

setup() {
add_plugins "${@}"
install_plugins "${@}"
}

main() {
local -r command="${1:-}"
shift
local -r tools=("${@}")
case "${command:-}" in
add) add_plugins "${tools[@]}" ;;
install) install_plugins "${tools[@]}" ;;
setup | '') setup "${tools[@]}" ;;
help) print_help ;;
*)
printf 'Invalid argument: "%s"\n' "${command}" >&2
print_help
return 1
;;
esac
}

check_asdf() {
command -v asdf >/dev/null || {
printf 'Please install asdf: https://asdf-vm.com/guide/getting-started.html#_3-install-asdf\n' >&2
return 1
}
}

array_contains() {
# Checks if first passed item, exists somewhere in the array passed as second and further arguments
local -r item="${1?Item required}"
shift
local -r arr=("${@}")
local other
for other in "${arr[@]}"; do
if [ "${item}" = "${other}" ]; then
return 0 # Found the item
fi
done
return 1 # didn't find the item
}

print_help() {
local -r script_called_name="${BASH_SOURCE[0]}"
printf 'Usage: %s <add|install|setup> [tool_names]\n' "${script_called_name}" >&2
printf 'Commands:\n' >&2
printf ' add - add to asdf plugins from .tool-versions file\n' >&2
printf ' install - install plugins which have been added into asdf and are versioned in .tool-versions file\n' >&2
printf ' setup - (default, if no command specified) and & install\n' >&2
printf 'Can additionally pass names of the tools to limit the install to\n' >&2
}

if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
main "$@"
fi
40 changes: 40 additions & 0 deletions .circleci/scripts/update_environment.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#!/usr/bin/env bash
set -euo pipefail
export LOGURU_LEVEL=TRACE
export GIT_SSH_COMMAND="fn circleci ssh -o IdentitiesOnly=yes -o IdentityAgent=none"

commit_author=$(git show --format="%aN <%aE>" --quiet)

args=(
--author "${commit_author}"
--update "${UPDATE}"
--release-train "latest"
--manifests-repo-url "${MANIFESTS_REPO}"
--manifests-base-branch "${MANIFESTS_BRANCH}"
--manifests-repo-ref "${MANIFESTS_BRANCH}"
--skip-pull-request
--push
)

if [ -n "${COMPONENT}" ]; then
args+=(--component "${COMPONENT}")
fi

retry_counter=10
errcode=1
while true; do
(( retry_counter-- )) || break

set +e
if fn --config-path "${JOB_ROOT}"/project/.opsninja.yaml \
manifests update "${args[@]}" "${ENVIRONMENT_PATH}"; then
errcode=0
break
else
errcode="${?}"
fi
set -e
sleep 1
done

exit $errcode
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -25,3 +25,6 @@ playwright-report

# Auto-generated icon file
/packages/grafana-ui/src/components/Icon/iconBundle.ts

# Sankey chart module.js
public/app/plugins/panel/sankey-panel-0.5.0/module.js
Loading