Skip to content

add Finnish translations #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

adamsitnik
Copy link
Member

fixes #2587

@KalleOlaviNiemitalo PTAL as I don't speak Finnish and the AI I've used could be wrong

@adamsitnik adamsitnik requested a review from Copilot June 30, 2025 17:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Finnish translation file to localize all existing resource strings into Finnish.

  • Introduces Resources.fi.xlf containing translated <trans-unit> entries for the entire resource set.
  • Sets the target language to Finnish (fi) and marks all units as translated.
  • Mirrors the structure of the English source resource file.

</trans-unit>
<trans-unit id="ArgumentConversionCannotParseForOption">
<source>Cannot parse argument '{0}' for option '{1}' as expected type '{2}'.</source>
<target state="translated">Valinnan '{1}' argumenttia '{0}' ei voi jäsentää odotetuksi tyypiksi '{2}'.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Option" in a command line is usually translated to "valitsin", not "valinta". So this should start with Valitsimen '{1}'. Likewise in ArgumentConversionCannotParseForOption_Completions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To verify, visit Microsoft Terminology Search and write command-line option in the Search source term field.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Valitsin" is like "selector"; a tool that is used for selecting.

"Valinta" is like "choice"; the act of choosing, or the thing that is chosen. Vaikea valinta, a difficult choice.

</trans-unit>
<trans-unit id="HelpOptionsTitle">
<source>Options:</source>
<target state="translated">Valinnat:</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here likewise Valitsimet:.

</trans-unit>
<trans-unit id="HelpUsageOptions">
<source>[options]</source>
<target state="translated">[valinnat]</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here likewise [valitsimet].

</trans-unit>
<trans-unit id="OptionExpectsOneArgument">
<source>Option '{0}' expects a single argument but {1} were provided.</source>
<target state="translated">Valinta '{0}' odottaa yhtä argumenttia, mutta {1} annettiin.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here likewise Valitsin '{0}'.

The verb "odottaa" feels a bit odd but I can't immediately suggest anything better.

</trans-unit>
<trans-unit id="OptionRequiredArgumentMissing">
<source>Required argument missing for option: '{0}'.</source>
<target state="translated">Pakollinen argumentti puuttuu valinnalta: '{0}'.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here likewise valitsimelta: '{0}'.

</trans-unit>
<trans-unit id="RequiredOptionWasNotProvided">
<source>Option '{0}' is required.</source>
<target state="translated">Valinta '{0}' on pakollinen.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here likewise Valitsin '{0}'.

</trans-unit>
<trans-unit id="VersionOptionCannotBeCombinedWithOtherArguments">
<source>{0} option cannot be combined with other arguments.</source>
<target state="translated">{0} valintaa ei voi yhdistää muihin argumentteihin.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here likewise valitsinta, but I'd also move it to the start of the sentence, Valitsinta {0} ei voi yhdistää muihin argumentteihin.

Copy link

@KalleOlaviNiemitalo KalleOlaviNiemitalo Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the word were not at the start of the sentence, then it would have to be combined with a hyphen {0}-valitsinta, but then that would look ambiguous when the {0} option itself contains hyphens, like --version.

Copy link

@KalleOlaviNiemitalo KalleOlaviNiemitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per previous comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support for Finnish language
2 participants