fix(esp_now): Fix broadcast example and use nullptr #11490
Conversation
lucasssvaz
added
the
Area: ESP-NOW
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 44s ⏱️ Results for commit 2b53ed1. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull Request Overview
This PR replaces all usages of NULL with nullptr for improved clarity and potential compiler optimizations, and fixes the ESP-NOW broadcast slave example.
- Update constructors, conditionals, and callback registrations to use nullptr.
- Modify the broadcast slave example to use pointer semantics for masters to avoid dangling pointers on vector reallocation.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libraries/ESP_NOW/src/ESP32_NOW_Serial.h and ESP32_NOW_Serial.cpp | Replaced NULL checks with nullptr in pointer assignments. |
| libraries/ESP_NOW/src/ESP32_NOW.h and ESP32_NOW.cpp | Replaced NULL with nullptr for consistency and modern C++ style. |
| libraries/ESP_NOW/examples/ESP_NOW_Network/ESP_NOW_Network.ino | Updated example to use nullptr; minor comment reordering. |
| libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave/ESP_NOW_Broadcast_Slave.ino | Changed broadcast peer initialization to use pointers. |
| libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master/ESP_NOW_Broadcast_Master.ino | Replaced NULL with nullptr; minor code consistency update. |
| ESP_NOW_Peer_Class *new_master = new ESP_NOW_Peer_Class(info->src_addr, ESPNOW_WIFI_CHANNEL, WIFI_IF_STA, nullptr); | ||
| if (!new_master->add_peer()) { | ||
| Serial.println("Failed to register the new master"); | ||
| delete new_master; | ||
| return; | ||
| } | ||
| masters.push_back(new_master); |
There was a problem hiding this comment.
[nitpick] Since master peers are now allocated using raw pointers and stored in a vector, consider using smart pointers (e.g., std::unique_ptr) to ensure proper resource management and avoid potential memory leaks.
| ESP_NOW_Peer_Class *new_master = new ESP_NOW_Peer_Class(info->src_addr, ESPNOW_WIFI_CHANNEL, WIFI_IF_STA, nullptr); | |
| if (!new_master->add_peer()) { | |
| Serial.println("Failed to register the new master"); | |
| delete new_master; | |
| return; | |
| } | |
| masters.push_back(new_master); | |
| auto new_master = std::make_unique<ESP_NOW_Peer_Class>(info->src_addr, ESPNOW_WIFI_CHANNEL, WIFI_IF_STA, nullptr); | |
| if (!new_master->add_peer()) { | |
| Serial.println("Failed to register the new master"); | |
| return; | |
| } | |
| masters.push_back(std::move(new_master)); |
Copilot uses AI. Check for mistakes.
Description of Change
Fixes broadcast slave example and replaces
NULLwithnullptrfor compiler optimizations.Tests scenarios
Tested locally
Related links
Closes #11165