Add baffling-birthdays #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiravillekode
force-pushed
the
baffling-birthdays
branch
3 times, most recently
from
02e8869 to
ac9e7d8
Compare
ahans
added
x:action/create
keiravillekode
force-pushed
the
baffling-birthdays
branch
from
ac9e7d8 to
c894da3
Compare
ahans
reviewed
May 29, 2025
|
|
||
| To do this, you need to: | ||
|
|
||
| - Generate random birthdates. |
There was a problem hiding this comment.
Creating random birthdays is not part of the exercise here. Do you think it would make sense to add an append to clarify that we don't do this here and maybe also give some reasoning?
| FUNC_PROTO = """\ | ||
| #include "vendor/unity.h" | ||
|
|
||
| #include <stddef.h> |
|
|
||
| void test_multiple_birthdates_with_more_than_one_shared_birthday(void) { | ||
| TEST_IGNORE(); | ||
| const char *birthdates[] = {"1966-07-29", "1977-02-12", "2001-12-25", "1980-07-29", "2019-02-12", NULL}; |
There was a problem hiding this comment.
Other tracks make this less about string parsing by using some Date structure that has year, month, and day fields. I think I would prefer that here as well, but if you prefer using the raw string format, fine as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.