-
Notifications
You must be signed in to change notification settings - Fork 62.1k
Update changing-your-primary-email-address.md #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes github#159 as suggested by its author.
Thanks @casals! I'm sending this over to @github/docs-content-core for review 🎈 |
Included callout tag for note
...thub/setting-up-and-managing-your-github-user-account/changing-your-primary-email-address.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @casals ✨ I left one suggestion for you, then we can get this merged in!
…t/changing-your-primary-email-address.md Applying requested changes Co-authored-by: Janice <janiceilene@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'll update the branch and merge once the tests are passing ⚡
* NFL tutorial draft * Wording * Remove redundant paragraph * Add comments * Wording * Add indexes * Add to query section (github#190) * Add to query section * make changes, delete python to put focus on sql * remove numpy Co-authored-by: Miranda Auhl <miranda@timescale.com> * Minor changes * Varchar --> text * Small changes from review Co-authored-by: Lana Brindley <github@lanabrindley.com> * Small changes part 2 Co-authored-by: Lana Brindley <github@lanabrindley.com> * Wording * Add player position and movement visualization * Take out python prerequisites * add other queries and fill analytics section (github#193) * add other queries and fill analytics section * updates * one last change * one last change to help merge Co-authored-by: Miranda Auhl <miranda@timescale.com> * add imag urls * Additional info about tables, fields * Add download links for datasets * update images to correct folder location * Add play drawing code and images * Fix image links * Add create_hypertable * Formatting and links * reorganization of the NFL tutorial, breaking it up into multiple pages. (github#202) * reorganization of the NFL tutorial, breaking it up into multiple pages. * Fixing links on first page * Updating both index pages with links and text * Apply suggestions from code review Lots of good cleanup thanks to Miranda and Lana! Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com> * Remove "TimescaleDB Toolkit" in place of hyperfunction * Made the tutorial more generic about time-series data * cleaned up section names in left nav * Added a little more exposition * Apply suggestions from code review add query info in relational page * Add queries to relational page * Apply suggestions from code review add comma to fix query * fix one part of the queries * Apply suggestions from code review apply cagg comments * Apply suggestions from code review update titles * add tables and some exposition Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com> Co-authored-by: Miranda Auhl <miranda@timescale.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Prashant Sridharan <prashant_sridharan@hotmail.com>
Why:
Fixes #159 as suggested by its author.
What's being changed:
Added some text before the procedure, stating that you cannot choose your backup email address as your primary.
Check off the following: