feat: Label Filter Case-Sensitivity Improvements #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by using the `--case-sensitive-labels` flag
There was a problem hiding this comment.
Pull Request Overview
This PR improves label filtering by adding support for case-sensitive matching when enabled via the --case-sensitive-labels flag. Key changes include adding a normalization helper to convert labels to lowercase, introducing a new boolean flag in the CLI, and updating tests and matching logic to account for case sensitivity.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/common/common.go | Added NormalizeArray() to convert arrays of strings to lowercase |
| internal/cmd/root.go | Introduced the --case-sensitive-labels flag and updated CLI examples |
| internal/cmd/match_criteria_test.go | Expanded tests to include cases for both case-sensitive and case-insensitive label matching |
| internal/cmd/match_criteria.go | Updated labelsMatch() to conditionally normalize label arrays based on the flag setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default make label matching case insensitive but make it sensitive by using the
--case-sensitive-labelsflagresolves: #9