Document add_sub_issue tool functionality #235
Conversation
aryasoni98
requested review from
juruen,
SamMorrowDrums,
williammartin and
toby
as code owners
|
@juruen @SamMorrowDrums @williammartin @toby Please review my PR . |
|
Thank you for your work. We have an upcoming PR that will require some changes to how tools are added to the server due to merge soon, and it will help to resolve issues with too many tools, so we appreciate your patience. We will resume merging new tools a bit faster after that, where they are a good fit. Sub-issues is definitely a powerful thing to add and that's not lost on us. I presume you can use your fork if you need this feature in the meantime. |
|
@aryasoni98 are you interested in continuing with this PR in light of Sam's comment here: #235 (comment) ? |
…n tools.go as per new project structure
@williammartin Yes, interested on this PR |
There was a problem hiding this comment.
@aryasoni98, I appreciate your desire to contribute to this server and would very much like to help you continue. However, I would ask that you take more steps to ensure the quality of contributions before requesting maintainer time. In this specific instance, this code cannot run the tests and does not compile.
➜ github-mcp-server git:(issues-196) go test ./...
# github.com/github/github-mcp-server/cmd/github-mcp-server
pkg/github/issues.go:14:2: no required module provides package github.com/mark3labs/mcp-go/mock; to add it:
go get github.com/mark3labs/mcp-go/mock
FAIL github.com/github/github-mcp-server/cmd/github-mcp-server [setup failed]
# github.com/github/github-mcp-server/internal/ghmcp
pkg/github/issues.go:14:2: no required module provides package github.com/mark3labs/mcp-go/mock; to add it:
go get github.com/mark3labs/mcp-go/mock
FAIL github.com/github/github-mcp-server/internal/ghmcp [setup failed]
# github.com/github/github-mcp-server/pkg/github
pkg/github/issues.go:14:2: no required module provides package github.com/mark3labs/mcp-go/mock; to add it:
go get github.com/mark3labs/mcp-go/mock
FAIL github.com/github/github-mcp-server/pkg/github [setup failed]
? github.com/github/github-mcp-server/cmd/mcpcurl [no test files]
ok github.com/github/github-mcp-server/pkg/log (cached)
ok github.com/github/github-mcp-server/pkg/toolsets (cached)
? github.com/github/github-mcp-server/pkg/translations [no test files]
FAIL
➜ github-mcp-server git:(issues-196) docker build -t github/github-mcp-server .
[+] Building 1.0s (10/12) docker:desktop-linux
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 953B 0.0s
=> [internal] load metadata for gcr.io/distroless/base-debian12:latest 0.0s
=> [internal] load metadata for docker.io/library/golang:1.24.2-alpine 0.5s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 185B 0.0s
=> [build 1/4] FROM docker.io/library/golang:1.24.2-alpine@sha256:7772cb5322baa875edd74705556d08f0eeca7b9c4b5367754ce3f2f00041ccee 0.0s
=> [stage-1 1/3] FROM gcr.io/distroless/base-debian12:latest 0.0s
=> [internal] load build context 0.2s
=> => transferring context: 251.73kB 0.2s
=> CACHED [build 2/4] WORKDIR /build 0.0s
=> CACHED [build 3/4] RUN --mount=type=cache,target=/var/cache/apk apk add git 0.0s
=> ERROR [build 4/4] RUN --mount=type=cache,target=/go/pkg/mod --mount=type=cache,target=/root/.cache/go-build --mount=type=bind,target=. CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=dev -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" -o /bin/github-mcp-server cmd/github-mcp-server/main.go 0.3s
------
> [build 4/4] RUN --mount=type=cache,target=/go/pkg/mod --mount=type=cache,target=/root/.cache/go-build --mount=type=bind,target=. CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=dev -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" -o /bin/github-mcp-server cmd/github-mcp-server/main.go:
0.245 pkg/github/issues.go:14:2: no required module provides package github.com/mark3labs/mcp-go/mock; to add it:
0.245 go get github.com/mark3labs/mcp-go/mock
------
Dockerfile:13
--------------------
12 | # go build automatically download required module dependencies to /go/pkg/mod
13 | >>> RUN --mount=type=cache,target=/go/pkg/mod \
14 | >>> --mount=type=cache,target=/root/.cache/go-build \
15 | >>> --mount=type=bind,target=. \
16 | >>> CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=${VERSION} -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
17 | >>> -o /bin/github-mcp-server cmd/github-mcp-server/main.go
18 |
--------------------
ERROR: failed to solve: process "/bin/sh -c CGO_ENABLED=0 go build -ldflags=\"-s -w -X main.version=${VERSION} -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)\" -o /bin/github-mcp-server cmd/github-mcp-server/main.go" did not complete successfully: exit code: 1
View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/sk8cma5sug8cub86pmjqg2lud
…rver signature, and correct translations import
|
@aryasoni98, I've asked you in #235 (review) to
And provided a specific example of where the quality was not up to standard. You've requested another review, and when I check it out I see that it again does not compile: Over on #351 I see that you have requested a review without addressing the failing tests. In fact, the commit message for 624b381 indicates that the tests pass which makes me wonder if this is pure AI contribution with no human review. Again, I appreciate your desire to contribute but this is not acceptable so I'm closing both of these PRs. If you would like feedback on a PR in future you may:
|
Closes: #196