Skip to content

chore(deps): bump github.com/docker/docker from 28.0.4+incompatible to 28.1.1+incompatible #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 21, 2025

Bumps github.com/docker/docker from 28.0.4+incompatible to 28.1.1+incompatible.

Release notes

Sourced from github.com/docker/docker's releases.

v28.1.1

28.1.1

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

Bug fixes and enhancements

  • Fix dockerd-rootless-setuptool.sh incorrectly reporting missing iptables. moby/moby#49833
  • containerd image store: Fix a potential daemon crash when using docker load with archives containing zero-size tar headers. moby/moby#49837

Packaging updates

Networking

  • Add a warning to a container's /etc/resolv.conf when no upstream DNS servers were found. moby/moby#49827

v28.1.0

28.1.0

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

New

  • Add docker bake sub-command as alias for docker buildx bake. docker/cli#5947
  • Experimental: add a new --use-api-socket flag on docker run and docker create to enable access to Docker socket from inside a container and to share credentials from the host with the container. docker/cli#5858
  • docker image inspect now supports a --platform flag to inspect a specific platform of a multi-platform image. docker/cli#5934

Bug fixes and enhancements

  • Add CLI shell-completion for context names. docker/cli#6016
  • Fix docker images --tree not including non-container images content size in the total image content size. docker/cli#6000
  • Fix docker load not preserving replaced images. moby/moby#49650
  • Fix docker login hints when logging in to a custom registry. docker/cli#6015
  • Fix docker stats not working properly on machines with high CPU core count. moby/moby#49734
  • Fix a regression causing docker pull/push to fail when interacting with a private repository. docker/cli#5964
  • Fix an issue preventing rootless Docker setup on a host with no ip_tables kernel module. moby/moby#49727
  • Fix an issue that could lead to unwanted iptables rules being restored and never deleted following a firewalld reload. moby/moby#49728
  • Improve CLI completion of docker service scale. docker/cli#5968
  • docker images --tree now hides both untagged and dangling images by default. docker/cli#5924
  • docker system info will provide an exit code if a connection cannot be established to the Docker daemon. docker/cli#5918

... (truncated)

Commits
  • 01f442b Merge pull request #49588 from thaJeztah/bump_go_build_tags
  • e03c0f0 Merge pull request #49834 from thaJeztah/cleanup_ignore
  • 8dde918 Merge pull request #49837 from thaJeztah/bump_containerd_2.0.5
  • e70ce7a Merge pull request #49833 from vvoland/rootless-iptables-check
  • fc8361c vendor: github.com/containerd/containerd v2.0.5
  • 62f51e4 vendor: golang.org/x/oauth2 v0.29.0
  • bbbb003 cleanup ignore files
  • ead379a contrib/rootless-setuptool: Fix iptables detection
  • 7c52c4d update go:build tags to go1.23 to align with vendor.mod
  • 6573a13 Merge pull request #49827 from robmry/warn_no_ext_nameservers
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Apr 21, 2025
@dependabot dependabot bot requested a review from a team as a code owner April 21, 2025 17:28
Copy link
Collaborator

@williammartin williammartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building an image from this branch:

➜  github-mcp-server git:(dependabot/go_modules/github.com/docker/docker-28.1.1incompatible) ✗ docker build -t github/github-mcp-server .
[+] Building 3.2s (16/16) FINISHED                                                                                                                                                                                                                                                                                                                                                                            docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                                                                                                                                                                                          0.0s
 => => transferring dockerfile: 926B                                                                                                                                                                                                                                                                                                                                                                                          0.0s
 => [internal] load metadata for gcr.io/distroless/base-debian12:latest                                                                                                                                                                                                                                                                                                                                                       0.0s
 => [internal] load metadata for docker.io/library/golang:1.23.7                                                                                                                                                                                                                                                                                                                                                              0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                                                                                                                                                                             0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                                                                                                                                                                               0.0s
 => [build 1/7] FROM docker.io/library/golang:1.23.7                                                                                                                                                                                                                                                                                                                                                                          0.0s
 => [internal] load build context                                                                                                                                                                                                                                                                                                                                                                                             0.5s
 => => transferring context: 1.81MB                                                                                                                                                                                                                                                                                                                                                                                           0.5s
 => [stage-1 1/3] FROM gcr.io/distroless/base-debian12:latest                                                                                                                                                                                                                                                                                                                                                                 0.0s
 => CACHED [build 2/7] WORKDIR /build                                                                                                                                                                                                                                                                                                                                                                                         0.0s
 => CACHED [build 3/7] RUN go env -w GOMODCACHE=/root/.cache/go-build                                                                                                                                                                                                                                                                                                                                                         0.0s
 => [build 4/7] COPY go.mod go.sum ./                                                                                                                                                                                                                                                                                                                                                                                         0.1s
 => [build 5/7] RUN --mount=type=cache,target=/root/.cache/go-build go mod download                                                                                                                                                                                                                                                                                                                                           1.3s
 => [build 6/7] COPY . ./                                                                                                                                                                                                                                                                                                                                                                                                     0.1s
 => [build 7/7] RUN --mount=type=cache,target=/root/.cache/go-build CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=dev -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)"     -o github-mcp-server cmd/github-mcp-server/main.go                                                                                                                                                       1.1s
 => CACHED [stage-1 2/3] WORKDIR /server                                                                                                                                                                                                                                                                                                                                                                                      0.0s
 => [stage-1 3/3] COPY --from=build /build/github-mcp-server .                                                                                                                                                                                                                                                                                                                                                                0.0s
 => exporting to image                                                                                                                                                                                                                                                                                                                                                                                                        0.0s
 => => exporting layers                                                                                                                                                                                                                                                                                                                                                                                                       0.0s
 => => writing image sha256:c7506aac58df9dab833e48deb23245cc1eb1c53fd73a88975e26e357f5c4106a                                                                                                                                                                                                                                                                                                                                  0.0s
 => => naming to docker.io/github/github-mcp-server                                                                                                                                                                                                                                                                                                                                                                           0.0s

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/xkiu4y01030qp05puv3tia4w6

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview

Using it in vscode:

{
    "inputs": [
        {
            "type": "promptString",
            "id": "github_token",
            "description": "GitHub Personal Access Token",
            "password": true
        }
    ],
    "servers": {
        "github": {
            "command": "docker",
            "args": [
                "run",
                "-i",
                "--rm",
                "-e",
                "GITHUB_PERSONAL_ACCESS_TOKEN",
                "github/github-mcp-server" <--------------
            ],
            "env": {
                "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_token}"
            }
        }
    }
}

Seeing it work:

image showing vscode agent using `search_repositories` from this build

@williammartin
Copy link
Collaborator

@dependabot rebase

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.0.4+incompatible to 28.1.1+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v28.0.4...v28.1.1)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-version: 28.1.1+incompatible
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/docker/docker-28.1.1incompatible branch from 50d1ebb to 3b6fd86 Compare April 22, 2025 13:36
@williammartin williammartin merged commit 3ca55bd into main Apr 22, 2025
16 checks passed
@williammartin williammartin deleted the dependabot/go_modules/github.com/docker/docker-28.1.1incompatible branch April 22, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant