Skip to content

Gitignore .vscode except launch.json #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

williammartin
Copy link
Collaborator

Description

Currently we gitignore .vscode/mcp.json because people are often developing this server in a vscode instance that has MCP configured. We also include a launch.json to aid in debugging.

What I'd like to do is allowlist just the launch.json, to require very intentional addition of vscode files. For example, I was surprised to see this:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        .vscode/.mcp.json.swp

@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 13:12
@williammartin williammartin requested a review from a team as a code owner April 22, 2025 13:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@williammartin williammartin force-pushed the wm/ignore-vscode-except-launch branch from eac014f to 1c03d12 Compare April 22, 2025 15:37
@williammartin williammartin merged commit cb8dfd1 into main Apr 22, 2025
16 checks passed
@williammartin williammartin deleted the wm/ignore-vscode-except-launch branch April 22, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants