Bump go-github to v72.0.0 #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radar07
force-pushed
the
bump-go-github-v72
branch
2 times, most recently
from
e6a3409 to
888dfb6
Compare
radar07
commented
May 30, 2025
| @@ -451,11 +451,11 @@ func ListIssues(getClient GetClientFn, t translations.TranslationHelperFunc) (to | |||
| } | |||
|
|
|||
| if page, ok := request.GetArguments()["page"].(float64); ok { | |||
| opts.Page = int(page) | |||
There was a problem hiding this comment.
The ListCursorOptions is added to IssueListOptions in v72 which has the same fields(Page and PerPage) like ListOptions. This line is changed to avoid ambiguity error.
radar07
force-pushed
the
bump-go-github-v72
branch
from
888dfb6 to
966807b
Compare
williammartin
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
LGTM, passes all the e2e tests:
➜ github-mcp-server git:(bump-go-github-v72) ✗ GOMAXPROCS=1 GITHUB_MCP_SERVER_E2E_HOST=https://github.com GITHUB_MCP_SERVER_E2E_TOKEN=$(gh auth token) go test -v -count=1 --tags e2e ./e2e
go: downloading github.com/google/go-github/v72 v72.0.0
=== RUN TestGetMe
=== PAUSE TestGetMe
=== RUN TestToolsets
=== PAUSE TestToolsets
=== RUN TestTags
=== PAUSE TestTags
=== RUN TestFileDeletion
=== PAUSE TestFileDeletion
=== RUN TestDirectoryDeletion
=== PAUSE TestDirectoryDeletion
=== RUN TestRequestCopilotReview
=== PAUSE TestRequestCopilotReview
=== RUN TestAssignCopilotToIssue
=== PAUSE TestAssignCopilotToIssue
=== RUN TestPullRequestAtomicCreateAndSubmit
=== PAUSE TestPullRequestAtomicCreateAndSubmit
=== RUN TestPullRequestReviewCommentSubmit
=== PAUSE TestPullRequestReviewCommentSubmit
=== RUN TestPullRequestReviewDeletion
=== PAUSE TestPullRequestReviewDeletion
=== CONT TestGetMe
e2e_test.go:80: Building Docker image for e2e tests...
e2e_test.go:163: Starting Stdio MCP client...
--- PASS: TestGetMe (16.27s)
=== CONT TestPullRequestReviewDeletion
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:1468: Getting current user...
e2e_test.go:1497: Creating repository williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1521: Creating branch in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1538: Creating commit with new file in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1555: Creating pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1570: Creating pending review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1588: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1615: Deleting review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1621: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
e2e_test.go:1506: Deleting repository williammartin/github-mcp-server-e2e-TestPullRequestReviewDeletion-1748854222631...
--- PASS: TestPullRequestReviewDeletion (6.68s)
=== CONT TestPullRequestReviewCommentSubmit
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:1223: Getting current user...
e2e_test.go:1252: Creating repository williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1276: Creating branch in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1293: Creating commit with new file in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1322: Creating pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1337: Creating pending review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1358: Adding file review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1378: Adding single line review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1400: Adding multi line review comment to pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1416: Submitting review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1430: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
e2e_test.go:1261: Deleting repository williammartin/github-mcp-server-e2e-TestPullRequestReviewCommentSubmit-1748854229313...
--- PASS: TestPullRequestReviewCommentSubmit (10.47s)
=== CONT TestPullRequestAtomicCreateAndSubmit
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:1063: Getting current user...
e2e_test.go:1092: Creating repository williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748854239725...
e2e_test.go:1116: Creating branch in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748854239725...
e2e_test.go:1133: Creating commit with new file in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748854239725...
e2e_test.go:1162: Creating pull request in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748854239725...
e2e_test.go:1179: Creating and submitting review for pull request in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748854239725...
e2e_test.go:1193: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748854239725...
e2e_test.go:1101: Deleting repository williammartin/github-mcp-server-e2e-TestPullRequestAtomicCreateAndSubmit-1748854239725...
--- PASS: TestPullRequestAtomicCreateAndSubmit (5.35s)
=== CONT TestAssignCopilotToIssue
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:960: Getting current user...
e2e_test.go:989: Creating repository williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748854245089...
e2e_test.go:1012: Creating issue in williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748854245089...
e2e_test.go:1026: Assigning copilot to issue in williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748854245089...
e2e_test.go:998: Deleting repository williammartin/github-mcp-server-e2e-TestAssignCopilotToIssue-1748854245089...
--- PASS: TestAssignCopilotToIssue (3.83s)
=== CONT TestRequestCopilotReview
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:812: Getting current user...
e2e_test.go:841: Creating repository williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748854248935...
e2e_test.go:865: Creating branch in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748854248935...
e2e_test.go:882: Creating commit with new file in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748854248935...
e2e_test.go:910: Creating pull request in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748854248935...
e2e_test.go:924: Requesting Copilot review for pull request in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748854248935...
e2e_test.go:936: Getting reviews for pull request in williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748854248935...
e2e_test.go:850: Deleting repository williammartin/github-mcp-server-e2e-TestRequestCopilotReview-1748854248935...
--- PASS: TestRequestCopilotReview (4.88s)
=== CONT TestDirectoryDeletion
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:614: Getting current user...
e2e_test.go:642: Creating repository williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821...
e2e_test.go:666: Creating branch in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821...
e2e_test.go:683: Creating commit with new file in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821...
e2e_test.go:701: Getting file contents in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821...
e2e_test.go:729: Deleting directory in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821...
e2e_test.go:743: Listing commits in williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821...
e2e_test.go:777: Getting commit williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821:282be2c5c8ee5f4edc38c37687d3d0c945e5a5c3...
e2e_test.go:651: Deleting repository williammartin/github-mcp-server-e2e-TestDirectoryDeletion-1748854253821...
--- PASS: TestDirectoryDeletion (5.05s)
=== CONT TestFileDeletion
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:422: Getting current user...
e2e_test.go:450: Creating repository williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880...
e2e_test.go:474: Creating branch in williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880...
e2e_test.go:491: Creating commit with new file in williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880...
e2e_test.go:506: Getting file contents in williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880...
e2e_test.go:534: Deleting file in williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880...
e2e_test.go:548: Listing commits in williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880...
e2e_test.go:582: Getting commit williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880:f64caba529d28f4cac1a07b1f435331d1fccc653...
e2e_test.go:459: Deleting repository williammartin/github-mcp-server-e2e-TestFileDeletion-1748854258880...
--- PASS: TestFileDeletion (5.30s)
=== CONT TestTags
e2e_test.go:163: Starting Stdio MCP client...
e2e_test.go:284: Getting current user...
e2e_test.go:313: Creating repository williammartin/github-mcp-server-e2e-TestTags-1748854264147...
e2e_test.go:330: Creating tag williammartin/github-mcp-server-e2e-TestTags-1748854264147:v0.0.1...
e2e_test.go:360: Listing tags for williammartin/github-mcp-server-e2e-TestTags-1748854264147...
e2e_test.go:393: Getting tag williammartin/github-mcp-server-e2e-TestTags-1748854264147:v0.0.1...
e2e_test.go:322: Deleting repository williammartin/github-mcp-server-e2e-TestTags-1748854264147...
--- PASS: TestTags (3.49s)
=== CONT TestToolsets
e2e_test.go:163: Starting Stdio MCP client...
--- PASS: TestToolsets (0.22s)
PASS
ok github.com/github/github-mcp-server/e2e 61.852s
|
Yes, I did it manually since I'm unaware of this thing. ごめんなさい 🙇 |
|
Not to worry. It's good to know that our workflow that checks this didn't handle this case correctly. I think we should probably just do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #455
I didn't encounter any errors while bumping the version. The tests are passing in my local. 😄