Fix position of 'Add your own activity' button #261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@The-Best-Codes you are the BEST! I've reconfigured the page all together and put the button on the top. TYSM for taking the time to open the issue and then doing the thing! Please DM me in x or LinkedIn I'd love to send you some stickers |
|
@AndreaGriffiths11 I will have to check out the updated page, glad you got a solution to that! 😀 |
|
@AndreaGriffiths11 my X account is The_Best_Codes. I can't message your account, it appears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #252
Before:
The add button is directly below the previous grid row in a non-obvious position.
Screenshot
After:
The button will be centered in the remaining space of the grid row, or take up the full width of the last row if the current row is full. It is responsive and easy to find.
Screenshot
Other options:
I could also put the button in a column next to the last card. Do you think this or the centered version (in the
Aftersection above) looks better?Screenshot
Be sure to tell me if there are any changes you want!