Skip to content

add security challenge page #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

add security challenge page #322

merged 1 commit into from
May 5, 2025

Conversation

abbycabs
Copy link
Member

@abbycabs abbycabs commented May 5, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 13:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Security Challenge page to the Maintainer Month site, including navigation support and a shield icon.

  • Introduces SecurityChallenge page with course listings and markdown-driven content
  • Adds IconShield component and hooks it into the header navigation
  • Updates routes and translation keys for the new page

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
public/icons/shield.js New shield SVG icon component
pages/security-challenge.js New Security Challenge page with markdown content
content/commons.json Added navigation label for security challenge
components/header/Header.jsx Added Shield icon and link for Security Challenge
common/routes.js Defined SECURITY_CHALLENGE route
Comments suppressed due to low confidence (2)

pages/security-challenge.js:48

  • [nitpick] The variable content_end uses snake_case. Rename it to contentEnd to follow JavaScript camelCase conventions.
const content_end = marked(`

content/commons.json:64

  • [nitpick] The navigation label "Challenge" is quite generic. Consider renaming it to "Security Challenge" for clarity in the menu.
    "navigation:security-challenge": "Challenge",

@abbycabs abbycabs merged commit fca7317 into main May 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant